Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Math.floor to Progress to get whole number progress #86

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Added Math.floor to Progress to get whole number progress #86

merged 2 commits into from
Feb 22, 2024

Conversation

CalebGerman
Copy link
Collaborator

@CalebGerman CalebGerman commented Feb 22, 2024 •
edited
Loading

image
image

@CalebGerman CalebGerman requested a review from a team as a code owner February 22, 2024 20:40
@CalebGerman CalebGerman requested a review from roluk February 22, 2024 20:40
mattbjordan
mattbjordan requested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@mattbjordan mattbjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Math.floor so that if the result is 99.67, you show 99% instead of 100%

@CalebGerman CalebGerman changed the title Added Math.ceil to Progress to get whole number progress Added Math.floor to Progress to get whole number progress Feb 22, 2024
@CalebGerman CalebGerman merged commit ab80a96 into master Feb 22, 2024
4 checks passed
@CalebGerman CalebGerman deleted the Cgerman/WholeNumberProgress branch February 22, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegopinate diegopinate diegopinate approved these changes

@mattbjordan mattbjordan mattbjordan approved these changes

@roluk roluk Awaiting requested review from roluk roluk is a code owner automatically assigned from iTwin/changed-elements

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CalebGerman @diegopinate @mattbjordan