Added new props for v2 widget and dialog provider that allows for job update call back and a toggle for toasts #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… update call back and a toggle for toasts.
CalebGerman
commented
Feb 26, 2024
packages/changed-elements-react/src/widgets/ChangedElementsWidget.tsx
Outdated
Show resolved
Hide resolved
diegopinate
reviewed
Feb 26, 2024
...d-elements-react/src/widgets/comparisonJobWidget/components/VersionCompareDialogProvider.tsx
Outdated
Show resolved
Hide resolved
...changed-elements-react/src/widgets/comparisonJobWidget/common/versionCompareV2WidgetUtils.ts
Show resolved
Hide resolved
...d-elements-react/src/widgets/comparisonJobWidget/components/VersionCompareDialogProvider.tsx
Outdated
Show resolved
Hide resolved
packages/changed-elements-react/src/widgets/ChangedElementsWidget.tsx
Outdated
Show resolved
Hide resolved
…get.tsx Co-authored-by: Diego Pinate <[email protected]>
…get.tsx Co-authored-by: Diego Pinate <[email protected]>
…t/components/VersionCompareDialogProvider.tsx Co-authored-by: Diego Pinate <[email protected]>
…t/components/VersionCompareDialogProvider.tsx Co-authored-by: Diego Pinate <[email protected]>
diegopinate
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… update call back and a toggle for toasts.