Force wrap long text #2431
Open
Force wrap long text #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r100-stack
requested review from
mayank99 and
smmr-dn
and removed request for
a team and
smmr-dn
mayank99
reviewed
Feb 13, 2025
| @@ -31,4 +31,5 @@ | |||
| $type: if(map.has-key($sizes, $type), $type, body); | |||
| font-size: map.get($sizes, $type); | |||
| font-weight: map.get($weights, $type); | |||
| overflow-wrap: anywhere; | |||
There was a problem hiding this comment.
Does word-break: break-word + hyphens: auto work instead of overflow-wrap: anywhere? I think that would be safer / have fewer undesirable results.
Edit: Actually, word-break: break-word is just an alias for overflow-wrap: anywhere. So hyphens: auto is the only important part of my comment.
Suggested change
| overflow-wrap: anywhere; | |
| overflow-wrap: anywhere; | |
| hyphens: auto; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added
overflow-wrap: anywherein theiui-textmixin to force the text wrap when the word is too long. Since this mixin is used in a few other places where text is used, this change is propagated there too.Affected components:
Text,NonIdealStatetitle and description,WorkflowDiagramstep,Stepperstep.Even though the mixin is used in other places too, like SideNavigation and Tag, I believe there is no change there since ellipses are shown and the text doesn't extend on multiple lines.
Testing
Screenshots
Textwith the text `"I'm a text. gyguftguyfgyfh…":NonIdealStatetitle:WorkflowDiagramstep:Stepperstep:Docs
Added changesets