Update theme bridge v5 variables based on v5.0.0-alpha.6
#2436
+104
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
reviewed
Feb 14, 2025
mayank99
reviewed
Feb 14, 2025
This reverts commit 07ac22b.
Merged
r100-stack
requested review from
mayank99 and
smmr-dn
and removed request for
a team
r100-stack
changed the title
v5.0.0-alpha.6
mayank99
reviewed
Feb 14, 2025
r100-stack
commented
Feb 14, 2025
| --iui-color-background-zebra: var(--iui-color-background); /* TODO: Use proper value when added */ | ||
| --iui-color-background: var(--ids-color-bg-page-base); | ||
| --iui-color-background-disabled: var(--ids-color-bg-glow-on-surface-disabled); | ||
| --iui-color-background-zebra: var(--ids-color-bg-page-zebra); |
There was a problem hiding this comment.
To confirm, am I using the zebra variable correctly? Because I saw little to no difference between the regular and zebra Table rows.
There was a problem hiding this comment.
Ah, good catch. It looks like this variable is not meant to be used on its own; it's supposed to be combined with bg-page-base.
For now, I would say let's keep using bg-page-base and leave the TODO there. It can be fixed in a future release.
There was a problem hiding this comment.
Suggested change
| --iui-color-background-zebra: var(--ids-color-bg-page-zebra); | |
| --iui-color-background-zebra: var(--iui-color-background); /* TODO: Use proper value when added */ |
mayank99
reviewed
Feb 15, 2025
| '@itwin/itwinui-react': patch | ||
| --- | ||
|
|
||
| Theme bridge uses latest token names introduced in `@itwin/[email protected]`. |
There was a problem hiding this comment.
It's more than token names; we can just say "breaking changes".
Suggested change
| Theme bridge uses latest token names introduced in `@itwin/[email protected]`. | |
| The **theme bridge** has been updated to handle the breaking changes introduced in `@itwin/[email protected]`. |
mayank99
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates the iTwinUI v5 variable names in the theme bridge to match those from the soon to be released
@itwin/[email protected]version.Since that alpha version also released a zebra background color (
--ids-color-bg-page-zebra), updated--iui-color-background-zebrato use that variable. (88edec5). However, not sure if I used that variable correctly because I saw little to no different of the zebra color from the regular background color.Updated the css-workshop and react-workshop to use
@itwin/[email protected].Testing
Docs