Making Schema names optional for Table Valued Functions #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # iModelCore/ECDb/ECDb/IssueReporter.cpp # iModelCore/ECDb/ECDb/IssueReporter.h
…eter inside InVirtualSet() or IdSet()....useful for BindIdSet()
SELECT x FROM (with cte(x) as(select ECInstanceId from meta.ECClassDef) select x from cte), test.IdSet('[1,2,3,4,5]') where id = x group by x
…and renamed _OnBeforeStep() to _ONBeforeFirstStep()
…VirtualTable_part2 # Conflicts: # iModelCore/ECDb/Tests/NonPublished/ECDbIdSetVirtualTableTests.cpp
# Conflicts: # iModelCore/ECDb/ECDb/BuiltInVTabs.cpp # iModelCore/ECDb/ECDb/ECSql/PragmaECSqlPreparedStatement.cpp # iModelCore/ECDb/ECDb/ECSql/ValueExp.cpp # iModelCore/ECDb/Tests/NonPublished/ConcurrentQueryTest_V2.cpp # iModelCore/ECDb/Tests/NonPublished/ECDbIdSetVirtualTableTests.cpp # iModelCore/ECDb/Tests/Performance/PerformanceIdSetTests.cpp
soham-bentley
requested review from
khanaffan,
pmconne,
calebmshafer,
rschili and
ColinKerr
as code owners
ColinKerr
reviewed
Jan 29, 2025
ColinKerr
approved these changes
Jan 29, 2025
ColinKerr
approved these changes
Jan 30, 2025
|
@Mergifyio backport release/4.11.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
* commit for new added test
* commit 2
* update
* Fixed all the issues related to filtering of data in Virtual Table
* Binder Type enhancement
* trying to fix BestIndex
* Fixed the single column issue in VT
* Performance Tests Added
* ValueExp_Issue_Id_Change due to conflicts while merging with main
* Added flag for binder info to check whether the binder is for a parameter inside InVirtualSet() or IdSet()....useful for BindIdSet()
* Tests Added
* Crash for following expression stopped by providing null checks
SELECT x FROM (with cte(x) as(select ECInstanceId from meta.ECClassDef) select x from cte), test.IdSet('[1,2,3,4,5]') where id = x group by x
* Kepping concurrentQueryImpl as close to as it was with minimal changes
* schema name changed to ECVLib and also file name changed
* cleanup
* more cleanup
* Performanvce Tests Updated
* some comments resolved
* Comments regarding constant name of IdSet table resolved
* binderInfo refactoring
* added flag to call _onbeforefirststep() once in PragmaECSQLStatement and renamed _OnBeforeStep() to _ONBeforeFirstStep()
* changes as per suggestions by Affan
* Performance test updated
* Tests updated to prevent failure in pipeline
* tests updated
* update in logic in IModelJsNative.cpp and concurrentquery
* performance tests indentation updated
* final update
* OnBeforeFirstStep() logic updated by using m_isFirstStep flag
* Commit for schema names optional in table valued functions
* More Tests added
* issue reporter update
* Added flag checking to m_isFirstStep flag so that when actually flag is false we reset it to true and vice versa
* logic update
* update
* update
* commiting update
* comment added
* comment added
* Tests added and updated
* removing m_isFirstStep and identifying first step using statement state
* Comment updated
* Fixed the issue with the query SELECT e.i FROM aps.TestElement e INNER JOIN ECVLib.IdSet(?) v ON e.ECInstanceId = v.id
* More tests added
* More Performance Tests added
* indentation issue solved
* Update in logic to get statement state
* Changelog updated
* comments updated
* Updates in code
* Tests added
* ECSql version updated
* Colin's comment resolved and appropriate tests added
---------
Co-authored-by: affank <[email protected]>
(cherry picked from commit ffc5996)
soham-bentley
added a commit
that referenced
this pull request
Feb 6, 2025
* commit for new added test
* commit 2
* update
* Fixed all the issues related to filtering of data in Virtual Table
* Binder Type enhancement
* trying to fix BestIndex
* Fixed the single column issue in VT
* Performance Tests Added
* ValueExp_Issue_Id_Change due to conflicts while merging with main
* Added flag for binder info to check whether the binder is for a parameter inside InVirtualSet() or IdSet()....useful for BindIdSet()
* Tests Added
* Crash for following expression stopped by providing null checks
SELECT x FROM (with cte(x) as(select ECInstanceId from meta.ECClassDef) select x from cte), test.IdSet('[1,2,3,4,5]') where id = x group by x
* Kepping concurrentQueryImpl as close to as it was with minimal changes
* schema name changed to ECVLib and also file name changed
* cleanup
* more cleanup
* Performanvce Tests Updated
* some comments resolved
* Comments regarding constant name of IdSet table resolved
* binderInfo refactoring
* added flag to call _onbeforefirststep() once in PragmaECSQLStatement and renamed _OnBeforeStep() to _ONBeforeFirstStep()
* changes as per suggestions by Affan
* Performance test updated
* Tests updated to prevent failure in pipeline
* tests updated
* update in logic in IModelJsNative.cpp and concurrentquery
* performance tests indentation updated
* final update
* OnBeforeFirstStep() logic updated by using m_isFirstStep flag
* Commit for schema names optional in table valued functions
* More Tests added
* issue reporter update
* Added flag checking to m_isFirstStep flag so that when actually flag is false we reset it to true and vice versa
* logic update
* update
* update
* commiting update
* comment added
* comment added
* Tests added and updated
* removing m_isFirstStep and identifying first step using statement state
* Comment updated
* Fixed the issue with the query SELECT e.i FROM aps.TestElement e INNER JOIN ECVLib.IdSet(?) v ON e.ECInstanceId = v.id
* More tests added
* More Performance Tests added
* indentation issue solved
* Update in logic to get statement state
* Changelog updated
* comments updated
* Updates in code
* Tests added
* ECSql version updated
* Colin's comment resolved and appropriate tests added
---------
Co-authored-by: affank <[email protected]>
(cherry picked from commit ffc5996)
Co-authored-by: Soham Bhattacharjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
itwinjs-core: iTwin/itwinjs-core#7630
Fixes https://github.com/iTwin/itwinjs-backlog/issues/1262