Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated all dependencies except eslint #170

Merged
merged 41 commits into from
Dec 6, 2024

Conversation

JonasDov
Copy link
Contributor

@JonasDov JonasDov commented Nov 29, 2024

  • Updated all dependencies to latest versions.
  • Updated all packages to esm instead of cjs as chai v5 supports only esm.
  • Removed webpack and added vite.
  • Removed chai, mocha and jest packages from e2e tests.
  • Added .env file with client id, since users can see it anyway. This allows running both: #local and #web tests on the pipeline.

@JonasDov JonasDov linked an issue Dec 4, 2024 that may be closed by this pull request
@JonasDov JonasDov marked this pull request as ready for review December 4, 2024 12:55
@JonasDov JonasDov requested a review from a team as a code owner December 4, 2024 12:55
presentation-rules-editor-react/tsconfig.build.json Outdated Show resolved Hide resolved
presentation-rules-editor-react/tsconfig.build.json Outdated Show resolved Hide resolved
presentation-rules-editor-react/package.json Outdated Show resolved Hide resolved
presentation-rules-editor-react/package.json Outdated Show resolved Hide resolved
app/frontend/src/app/App.tsx Outdated Show resolved Hide resolved
app/e2e-tests/package.json Outdated Show resolved Hide resolved
app/e2e-tests/tsconfig.json Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@grigasp
Copy link
Member

grigasp commented Dec 5, 2024

I looked at the fonts situation and found that we're not using "Open Sans" at all since switching to itwinui-react version 3. That means we unnecessarily download the "Open Sans" font... IMO, we can just remove the font optimization stuff:

  • remove app/frontend/public/fonts,
  • remove the "Optimizing fonts" section from CONTRIBUTING.md.

@JonasDov
Copy link
Contributor Author

JonasDov commented Dec 6, 2024

I looked at the fonts situation and found that we're not using "Open Sans" at all since switching to itwinui-react version 3. That means we unnecessarily download the "Open Sans" font... IMO, we can just remove the font optimization stuff:

  • remove app/frontend/public/fonts,
  • remove the "Optimizing fonts" section from CONTRIBUTING.md.

Thanks for looking into it.
Removed

@JonasDov JonasDov merged commit e697472 into master Dec 6, 2024
4 checks passed
@JonasDov JonasDov deleted the JonasD/update-dependencies-fresh branch December 6, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to latest dependencies
2 participants