Quiz registration #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atnanahidiw
reviewed
Oct 24, 2023
There was a problem hiding this comment.
Cool 🚀 I can confirm that the new quiz has been added to the list & firestore already 🙌
Some minor fixes are still needed, though:
- After clicking the group button, it seems like you forgot to close the modal
- The quiz list should be ordered by
quiz_start_atDESC, maybe can use https://firebase.google.com/docs/firestore/query-data/order-limit-data when fetching the data
app/lib/features/quiz_registration/presentation/pages/quiz_registration_page.dart
Outdated
Show resolved
Hide resolved
app/lib/features/quiz_registration/presentation/pages/quiz_registration_page.dart
Outdated
Show resolved
Hide resolved
|
LGTM #telat |
This was
linked to
issues
Oct 25, 2023
2 tasks
|
refence for firestore index in order by query |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.