fix: last modified at field after uploading files #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadeksuryam
changed the title
fushar
requested changes
Nov 17, 2023
There was a problem hiding this comment.
@kadeksuryam Thanks for the contribution! The idea is solid. Left some comments.
judgels-backends/judgels-commons/judgels-fs/src/main/java/judgels/fs/FileSystem.java
Show resolved
Hide resolved
judgels-backends/judgels-commons/judgels-fs/src/main/java/judgels/fs/FileSystem.java
Show resolved
Hide resolved
judgels-backends/judgels-server-app/src/main/java/judgels/sandalphon/LocalGit.java
Show resolved
Hide resolved
fushar
reviewed
Nov 17, 2023
judgels-backends/judgels-commons/judgels-fs/src/main/java/judgels/fs/local/LocalFileSystem.java
Show resolved
Hide resolved
fushar
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #540
Root Cause:
Git doesn't actually record timestamps for files. Consequently, when a repository is cloned, the timestamp becomes the current time.
Solution:
Rather than using the git clone API, I utilize the filesystem API to recursively copy one git directory to another and subsequently set the origin URI.