Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Back not reflect proper state in profile #559

Merged
merged 2 commits into from
Dec 1, 2023
Merged

fix: Back not reflect proper state in profile #559

merged 2 commits into from
Dec 1, 2023

Conversation

rwhendry
Copy link
Contributor

@rwhendry rwhendry commented Dec 1, 2023

Resolves: #405

Issues happened because the username hadn't properly loaded by jophiel causing the API to call the persisted username for submission-history and contest-history

fushar
fushar approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah........... right. I wanted to get rid of these hacks in the codebase but didn't have time to clean up. Thanks for noticing!

@fushar fushar merged commit b5e8eae into ia-toki:master Dec 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fushar fushar fushar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Going back to someone's contest history may show yours instead
2 participants
@rwhendry @fushar