IBX-9489: [OSS] UncaughtTypeError after entering 'Content structure' #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dew326
approved these changes
Feb 5, 2025
bozatko
approved these changes
Feb 5, 2025
lucasOsti
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR reverts changing order of operations introduced in https://github.com/ibexa/admin-ui/pull/1409/files#diff-bf77db8b51e34024d4e5a4296543fbdca4b437d11f43b61d4de71482b7b5c794R33
That's not perfect solution, as it breaks rules of hooks (early return before hooks), but this check has to be done here, as all these contexts doesn't exist outside UDW. In a perfect world, this
isUDWcheck should be done in parent before rendering this component, but parent is class component, so it can't use context from hooks...For QA:
Documentation: