Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding condition to display sorting options #916

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Adding condition to display sorting options #916

merged 4 commits into from
Nov 7, 2023

Conversation

lionelakpagni
Copy link
Contributor

@lionelakpagni lionelakpagni commented Sep 25, 2023 •
edited
Loading

Question Answer
Tickets IBX-6004
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes/no
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@lionelakpagni lionelakpagni requested a review from a team September 25, 2023 12:49
@lionelakpagni lionelakpagni marked this pull request as ready for review September 25, 2023 12:49
@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Sep 26, 2023
@bogusez bogusez self-assigned this Oct 4, 2023
This was referenced Oct 4, 2023
Closed
Closed
@lionelakpagni lionelakpagni force-pushed the IBX-6004-Remove-Sub-item-sorting-options-from-tag-detail-view branch from 8f8179f to 8c7600d Compare October 4, 2023 08:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bogusez
Copy link
Contributor

bogusez commented Oct 4, 2023 •
edited
Loading

@lionelakpagni there is a java script exception when user go to Content / Tags in back office.

Screenshot 2023-10-04 at 11 13 26

@bogusez
Copy link
Contributor

bogusez commented Oct 16, 2023

@lionelakpagni there is a java script exception when user go to Content / Tags in back office.

Screenshot 2023-10-04 at 11 13 26

@lionelakpagni any updates?

@adamwojs
Copy link
Member

adamwojs commented Nov 2, 2023

@lionelakpagni Could you please address @bogusez comments?

@lionelakpagni
Copy link
Contributor Author

@lionelakpagni there is a java script exception when user go to Content / Tags in back office.
Screenshot 2023-10-04 at 11 13 26

@lionelakpagni any updates?

Hi @bogusez ! Sorry for late feedback; As we discused it yesterday, this fix is ready, PR will be update soon. Currently on some urgent topics

@lionelakpagni
Copy link
Contributor Author

@lionelakpagni Could you please address @bogusez comments?

Hi @adamwojs yes , I have discussed it with him yesterday, PR will be update next week. Thanks

@lionelakpagni lionelakpagni force-pushed the IBX-6004-Remove-Sub-item-sorting-options-from-tag-detail-view branch from 8c7600d to 0de5ca9 Compare November 6, 2023 14:22
This was referenced Nov 7, 2023
Closed
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bogusez
Copy link
Contributor

bogusez commented Nov 7, 2023

Regression tests passed:
ibexa/experience#263
ibexa/commerce#446

@webhdx webhdx merged commit 64cb42c into 4.5 Nov 7, 2023
17 checks passed
@webhdx webhdx deleted the IBX-6004-Remove-Sub-item-sorting-options-from-tag-detail-view branch November 7, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

@bogusez bogusez

Labels
Bug Something isn't working QA approved Ready for MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.