Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed duplicated class key in drowdown_widget.html.twig #962

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Removed duplicated class key in drowdown_widget.html.twig #962

merged 1 commit into from
Oct 30, 2023

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Oct 28, 2023 •
edited
Loading

Question Answer
Tickets N/A
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

class is already passed to @ibexadesign/ui/component/dropdown/dropdown.html.twig in line 19.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@adamwojs adamwojs requested review from dew326 and a team October 28, 2023 18:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@adamwojs adamwojs merged commit cb387bb into 4.5 Oct 30, 2023
@adamwojs adamwojs deleted the adamwojs-patch-1 branch October 30, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dew326 dew326 dew326 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamwojs @dew326