Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Behat] IBX-6849: fixed rte buttons positions #979

Closed
wants to merge 1 commit into from
Closed

[Behat] IBX-6849: fixed rte buttons positions #979

wants to merge 1 commit into from

Conversation

tomaszszopinski
Copy link
Contributor

@tomaszszopinski tomaszszopinski commented Nov 7, 2023 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6849
Bug fix? no
New feature? yes
BC breaks? no

This PR fixes CI errors from https://github.com/ibexa/page-builder/pull/281. Due to block config panel being bigger RTE editor button positions have changed.

Green multiple pr build - ibexa/commerce#449

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mnocon
mnocon approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think that we should be able to leverage #945 and get rid of the hardcoded positions - but I need to test it first

In the meantime this solves our issue, so +1 💪

@tomaszszopinski
Copy link
Contributor Author

Closed in favor of #980

@tomaszszopinski tomaszszopinski deleted the IBX-6849-rte-toolbar-positions-updated branch September 3, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@mnocon mnocon mnocon approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@ViniTou ViniTou

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tomaszszopinski @mnocon @lucasOsti @katarzynazawada @bogusez @mikadamczyk @Nattfarinn @ciastektk @ViniTou