Refactored Float and Integer field types to use external validators #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
ibx-8138/numeric-ft-validators-dry-fix
branch
2 times, most recently
from
acdb802 to
f7b774e
Compare
adamwojs
reviewed
Aug 28, 2024
Steveb-p
reviewed
Aug 28, 2024
…Test Co-Authored-By: Adam Wójs <[email protected]>
Co-Authored-By: Paweł Niedzielski <[email protected]>
alongosz
force-pushed
the
ibx-8138/numeric-ft-validators-dry-fix
branch
from
9a56748 to
8493436
Compare
|
|
Update: added via a887e22 missing return types to |
konradoboza
approved these changes
Aug 28, 2024
Steveb-p
approved these changes
Aug 28, 2024
barw4
pushed a commit
that referenced
this pull request
Oct 17, 2024
…425) For more details see #425 Key changes: * Refactored Float and Integer field types to use external validators * [Tests] Refactored Float, Integer, and String validator tests --------- Co-authored-by: Adam Wójs <[email protected]> Co-authored-by: Paweł Niedzielski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This PR delegates redundant validation code in Float and Integer field types to proper, already existing validators.
Also refactored tests, including tests for String validator due to similarities.
I've moved scope-affected Integer, Float, and String Validator test classes to the correct Validator namespace, reflecting better src namespace structure.
For QA:
Regression build should be enough (ibexa/commerce#1010).