Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8543: Verify newer DBMS versions #470

Draft
wants to merge 2 commits into
base: 4.6
Choose a base branch
from
Draft

IBX-8543: Verify newer DBMS versions #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21c4c83
IBX-8543: Verify newer DBMS versions
micszo Jan 28, 2025
9b3fe8c
collationFixedCriterion
micszo Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
needs: tests
services:
postgres:
image: postgres:10
image: postgres:14
ports:
- 5432
env:
Expand Down Expand Up @@ -131,7 +131,7 @@ jobs:
needs: tests
services:
mysql:
image: mysql:5.7
image: mysql:8.0
ports:
- 3306/tcp
env:
Expand Down
15 changes: 13 additions & 2 deletions tests/integration/Core/Repository/SearchService/RemoteIdIndexingTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,20 @@

$contentId = self::$contentIdByRemoteIdIndex[$remoteId];

// ensure correct collation for comparison
$collationFixedCriterion = new Criterion\RemoteId([

Check failure on line 59 in tests/integration/Core/Repository/SearchService/RemoteIdIndexingTest.php

View workflow job for this annotation

GitHub Actions / Unit tests & SQLite integration tests (7.4) 

Parameter #1 $value of class Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\RemoteId constructor expects array<string>|string, array<int, Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\LogicalAnd> given.

Check failure on line 59 in tests/integration/Core/Repository/SearchService/RemoteIdIndexingTest.php

View workflow job for this annotation

GitHub Actions / Unit tests & SQLite integration tests (8.0) 

Parameter #1 $value of class Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\RemoteId constructor expects array<string>|string, array<int, Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\LogicalAnd> given.

Check failure on line 59 in tests/integration/Core/Repository/SearchService/RemoteIdIndexingTest.php

View workflow job for this annotation

GitHub Actions / Unit tests & SQLite integration tests (8.1) 

Parameter #1 $value of class Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\RemoteId constructor expects array<string>|string, array<int, Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\LogicalAnd> given.
new Criterion\LogicalAnd([

Check failure on line 60 in tests/integration/Core/Repository/SearchService/RemoteIdIndexingTest.php

View workflow job for this annotation

GitHub Actions / Unit tests & SQLite integration tests (7.4) 

Parameter #1 $criteria of class Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\LogicalAnd constructor expects array<Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion>, array<int, Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\Comparison> given.

Check failure on line 60 in tests/integration/Core/Repository/SearchService/RemoteIdIndexingTest.php

View workflow job for this annotation

GitHub Actions / Unit tests & SQLite integration tests (8.0) 

Parameter #1 $criteria of class Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\LogicalAnd constructor expects array<Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion>, array<int, Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\Comparison> given.

Check failure on line 60 in tests/integration/Core/Repository/SearchService/RemoteIdIndexingTest.php

View workflow job for this annotation

GitHub Actions / Unit tests & SQLite integration tests (8.1) 

Parameter #1 $criteria of class Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\LogicalAnd constructor expects array<Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion>, array<int, Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\Comparison> given.
new Criterion\Comparison(

Check failure on line 61 in tests/integration/Core/Repository/SearchService/RemoteIdIndexingTest.php

View workflow job for this annotation

GitHub Actions / Unit tests & SQLite integration tests (7.4) 

Instantiated class Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\Comparison not found.

Check failure on line 61 in tests/integration/Core/Repository/SearchService/RemoteIdIndexingTest.php

View workflow job for this annotation

GitHub Actions / Unit tests & SQLite integration tests (8.0) 

Instantiated class Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\Comparison not found.

Check failure on line 61 in tests/integration/Core/Repository/SearchService/RemoteIdIndexingTest.php

View workflow job for this annotation

GitHub Actions / Unit tests & SQLite integration tests (8.1) 

Instantiated class Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\Comparison not found.
'remote_id',
Criterion\Operator::EQ,
$remoteId . " COLLATE utf8mb4_unicode_ci"
)
])
]);

// test searching using both Content & Location remote IDs for both Content items
$query = new Query();
$query->filter = $criterion;
$query->filter = $collationFixedCriterion;
$result = $searchService->findContent($query);
self::assertSame(
1,
Expand All @@ -67,7 +78,7 @@
self::assertSame($contentId, $result->searchHits[0]->valueObject->id);

$query = new LocationQuery();
$query->filter = $criterion;
$query->filter = $collationFixedCriterion;
$result = $searchService->findLocations($query);
self::assertSame(
1,
Expand Down
Loading