Fix/Update PHPStan after PHPDoc enhancement #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use advanced format in summary, it won't be rendered.
Don't use advanced format in summary, it won't be rendered. Define array key type, or it will be rendered as array<string|int, …> phpDocumentor don't seem to understand self.
One docblock per constant.
- Describes a bit more `getProperties` - Details `getProperties` param type and returned type - Hides link to internal function - Uses `@internal` as a short for "@ignore This method is for internal use" - Fixes internal links
…internal" This reverts commit 44aede1.
Revert 1799d56 changes on src/lib/Limitation/ as this is out of contracts scope.
Method Ibexa\Contracts\Core\Limitation\Type::valueSchema() has invalid return type Ibexa\Contracts\Core\Limitation\Traversable. To fix this, it's possible do add a leading backslash, but it throws a new error: Method Ibexa\Contracts\Core\Limitation\Type::valueSchema() return type has no value type specified in iterable type Traversable. See: https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type
…$properties change $properties has now value type specified
adriendupuis
commented
Feb 3, 2025
Too difficult to solve in this PR
# Conflicts: # src/contracts/Limitation/Type.php
"return type has no value type specified in iterable type iterable"
adriendupuis
force-pushed
the
enh-phpdoc
branch
from
4aaeeea to
5f681f9
Compare
|
|
To properly fix local PHPStan analyse for PHP 8.1, I had to rethink my usage, and stop using default PHP (8.4): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Sub-PR for #463
Description:
For QA:
Documentation: