-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge branch '2.3' of ezsystems/ezplatform-http-cache into 4.6 #55
Conversation
@glye you have conflicts here. Does github now generate those commits like "Merge commit from fork"? Keep in mind that commit like this won't be visible in auto-generated changelogs. However we can merge this PR adding |
@alongosz The "Merge commit from fork" is automatic, yes. |
Quality Gate passedIssues Measures |
@alongosz Manual merge done, hope I didn't 🪛 it up. |
I don't have access to it @glye (: |
@alongosz Sorry, I removed it already. But I'm pretty sure I got it right :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to dig deep enough to have some further context on compression, but it feels like we are skipping it for some important content types (REST-related, JSON). I wonder if that has any repercussions on performance but I guess that wasn't checked, wasn't that? +1 to unblock release.
Yes, there can be a performance impact, but fixing it in other ways than turning off compression is a hard problem to solve, with security pitfalls. Ref. https://www.breachattack.com/ |
At least rate-limiting looks like potential low-hanging fruit, but this still only reduces the breach probability. Thanks for the details @glye. |
Cross merge PR