IBX-8365: Use babel to automatic refactor frontend code #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
reviewed
Aug 7, 2024
|
|
||
| module.exports = function (api) { | ||
| const modifyPlugins = getModifyMethod('plugins'); | ||
|
|
| @@ -0,0 +1,193 @@ | |||
| # How to run | |||
There was a problem hiding this comment.
Not yet, as stated in PR's TODO it has to be adjusted a little, but I'd rather do it after CR of rest in case of you find some glaring error. :)
| `--cwd` argument should point to directory where JS transform module is installed (for example `./vendor/ibexa/rector/js`). | ||
|
|
||
| ## Customizable variables | ||
| ### REMOVEEZ_CONFIG |
There was a problem hiding this comment.
Suggested change
| ### REMOVEEZ_CONFIG | |
| ### REMOVE_EZ_CONFIG |
?
| ``` | ||
| { | ||
| "ibexa-rename-string-values": { | ||
| "ezform-error": "ibexaform-error", |
There was a problem hiding this comment.
Suggested change
| "ezform-error": "ibexaform-error", | |
| "ezform-error": "ibexa-form-error", |
?
There was a problem hiding this comment.
Probably classes at both sides are wrong and there should be ez-form-error as well, whoops
Unless it's something that came from form-builder, need to recheck
lucasOsti
reviewed
Aug 20, 2024
| traverse(moduleConfig, path.node.name, (oldValue, newValue) => { | ||
| const newIdentifier = path.node.name.replace(oldValue, newValue); | ||
|
|
||
| path.node.name = t.toIdentifier(newIdentifier); |
There was a problem hiding this comment.
maybe we should use a different variable name than just t?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Description:
For QA:
Documentation: