Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed leftover legacy namespace #93

Closed
wants to merge 5 commits into from
Closed

Fixed leftover legacy namespace #93

wants to merge 5 commits into from

Conversation

konradoboza
Copy link
Contributor

🎫 Issue -

Description:

I also fixed one small issue with unused test property.

For QA:

Documentation:

@konradoboza konradoboza requested review from a team, Steveb-p and alongosz May 20, 2024 10:51
@konradoboza konradoboza mentioned this pull request May 20, 2024
Merged
ViniTou
ViniTou reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@ViniTou ViniTou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed for 4.6 branch as well as this is result of this cross merge.
#58

@konradoboza konradoboza force-pushed the fixed-legacy-namespace-leftovers branch from cbcfce8 to 5669d6b Compare May 20, 2024 11:23
@konradoboza konradoboza changed the base branch from main to 4.6 May 20, 2024 11:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
19.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@konradoboza konradoboza deleted the fixed-legacy-namespace-leftovers branch May 20, 2024 11:24
@konradoboza
Copy link
Contributor Author

Closed in favor of #94.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou left review comments

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@tischsoic tischsoic

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@konradoboza @Steveb-p @alongosz @ViniTou @tischsoic @ibexa-yuna