Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Dropped providing fallback Test Kernel if not defined #10

Merged
merged 1 commit into from
May 6, 2024

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Mar 5, 2024

Question Answer
JIRA issue n/a
Type improvement
Target Ibexa version v5.0
BC breaks yes

Returning default core Kernel if none was defined has proven to cause debugging issues when someone forgets to define it but expect his kernel is actually being the one used.

The idea behind this adjustment to Symfony Test Kernel was to help with simpler setups, however in practice simpler setup is never used, because each kernel needs to define at least its own bundle.

Therefore removing it. If kernel was not configured, it will cause a LogicException when running tests. If indeed for some edge case a custom kernel is not needed, one can simply mitigate the issue by explicitly configuring KERNEL_CLASS as Ibexa\Contracts\Test\Core\IbexaTestKernel.

TODO

  • Try using multi-repo tools to check integration tests for all relevant 1st party packages.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly.
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review.

@alongosz alongosz merged commit ee988aa into main May 6, 2024
7 of 10 checks passed
@alongosz alongosz deleted the tests-drop-fallback-kernel branch May 6, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants