Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review #1

Merged
merged 1 commit into from
Dec 4, 2024
Merged

review #1

merged 1 commit into from
Dec 4, 2024

Conversation

memsharded
Copy link

@memsharded memsharded commented Nov 23, 2024

Just some simplifications while trying to understand the project related to issue conan-io/conan#17324

I have added a python build.py script that shows exactly the errors or working behavior.
At this moment it works because:

  • I am not modifying the binaryDir to include that ${buildPresets]
  • Removed the build_folder_vars definition

I suspect there might be a gap in the definition of custom presets for multi-config, the "conan-default" equivalent but for user defined names. I am still learning how the ${buildPresets] is supposed to work there in the binaryDir.

@ibis-hdl
Copy link
Owner

Thank you for investigating! I'm reassured that you were able to reproduce it - everything works with the default build path.
I have just made the conan_install.py script the same in all branches. As I saw afterward, you also noticed this (pathlib.Path).
Unfortunately, I also made Pwsh settings (Windows) for my VS Code settings today, which actually belong in the local host/user settings of VS Code - not here in the repo. I hope you are not affected - otherwise I will take them back.

@ibis-hdl ibis-hdl merged commit 29d7d61 into ibis-hdl:setting-buildDir Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants