test: fix broken and/or failing tests

ibis-project · Dec 15, 2024 · 627568a · 627568a
1 parent fe54895
commit 627568a
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 16 deletions.
diff --git a/ibis/backends/tests/test_aggregation.py b/ibis/backends/tests/test_aggregation.py
@@ -470,12 +470,19 @@ def mean_and_std(v):
             lambda t, where: t.string_col.approx_nunique(where=where),
             lambda t, where: t.string_col[where].nunique(),
             id="approx_nunique",
-            marks=pytest.mark.xfail_version(
-                duckdb=["duckdb>=1.1"],
-                raises=AssertionError,
-                reason="not exact, even at this tiny scale",
-                strict=False,
-            ),
+            marks=[
+                pytest.mark.xfail_version(
+                    duckdb=["duckdb>=1.1"],
+                    raises=AssertionError,
+                    reason="not exact, even at this tiny scale",
+                    strict=False,
+                ),
+                pytest.mark.notimpl(
+                    ["datafusion"],
+                    reason="data type is not supported",
+                    raises=Exception,
+                ),
+            ],
         ),
         param(
             lambda t, where: t.bigint_col.bit_and(where=where),

diff --git a/ibis/backends/tests/test_examples.py b/ibis/backends/tests/test_examples.py
@@ -16,7 +16,9 @@
     reason="nix on linux cannot download duckdb extensions or data due to sandboxing",
 )
 @pytest.mark.notimpl(["pyspark", "exasol", "databricks"])
-@pytest.mark.notyet(["clickhouse", "druid", "impala", "mssql", "trino", "risingwave"])
+@pytest.mark.notyet(
+    ["clickhouse", "druid", "impala", "mssql", "trino", "risingwave", "datafusion"]
+)
 @pytest.mark.parametrize(
     ("example", "columns"),
     [

diff --git a/ibis/backends/tests/test_expr_caching.py b/ibis/backends/tests/test_expr_caching.py
@@ -127,7 +127,7 @@ def test_persist_expression_repeated_cache(alltypes, con):
     assert name not in con.list_tables()
 
 
-@mark.notimpl(["datafusion", "flink", "impala", "trino", "druid"])
+@mark.notimpl(["flink", "impala", "trino", "druid"])
 @mark.notimpl(["exasol"], reason="Exasol does not support temporary tables")
 @pytest.mark.never(
     ["risingwave"],

diff --git a/ibis/backends/tests/tpc/ds/test_queries.py b/ibis/backends/tests/tpc/ds/test_queries.py
@@ -2072,11 +2072,6 @@ def test_40(catalog_sales, catalog_returns, warehouse, item, date_dim):
 
 
 @tpc_test("ds")
-@pytest.mark.notyet(
-    ["datafusion"],
-    raises=Exception,
-    reason="Error during planning: Correlated column is not allowed in predicate",
-)
 @pytest.mark.notyet(
     ["clickhouse"],
     raises=ClickHouseDatabaseError,
@@ -2230,9 +2225,6 @@ def test_44(store_sales, item):
 
 
 @tpc_test("ds")
-@pytest.mark.notyet(
-    ["datafusion"], raises=Exception, reason="Unsupported feature in DataFusion SQL"
-)
 def test_45(web_sales, customer, customer_address, date_dim, item):
     return (
         web_sales.join(customer, [("ws_bill_customer_sk", "c_customer_sk")])
@@ -4647,6 +4639,7 @@ def items(returns, *, prefix):
 
 
 @tpc_test("ds")
+@pytest.mark.notyet(["datafusion"], reason="coercion failure", raises=Exception)
 def test_84(
     customer,
     customer_address,