Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump 3.12 usage to 3.13 #10588

Merged
merged 4 commits into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check-generated-files.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
uses: actions/setup-python@v5
id: install_python
with:
python-version: "3.12"
python-version: "3.13"
cache: pip
cache-dependency-path: requirements-dev.txt

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ibis-backends-cloud.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
matrix:
python-version:
- "3.10"
- "3.12"
- "3.13"
backend:
- name: snowflake
title: Snowflake
Expand All @@ -58,7 +58,7 @@ jobs:
title: BigQuery
extras:
- --extra bigquery
- python-version: "3.12"
- python-version: "3.13"
backend:
name: bigquery
title: BigQuery
Expand Down
45 changes: 40 additions & 5 deletions .github/workflows/ibis-backends.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
- windows-latest
python-version:
- "3.10"
- "3.12"
- "3.13"
steps:
- name: checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:
- windows-latest
python-version:
- "3.10"
- "3.12"
- "3.13"
backend:
- name: duckdb
title: DuckDB
Expand Down Expand Up @@ -258,7 +258,42 @@ jobs:
sys-deps:
- cmake
- ninja-build
# pytorch wheel doesn't exist for windows + python 3.13, so test
# against 3.12 until that's shipped
- os: windows-latest
python-version: "3.12"
backend:
name: duckdb
title: DuckDB
serial: true
extras:
- --extra duckdb
- --extra deltalake
- --extra geospatial
- --extra examples
- --extra decompiler
- --extra polars
additional_deps:
- torch
# also test duckdb with python 3.13 on windows, *without* pytorch
- os: windows-latest
python-version: "3.13"
backend:
name: duckdb
title: DuckDB
serial: true
extras:
- --extra duckdb
- --extra deltalake
- --extra geospatial
- --extra examples
- --extra decompiler
- --extra polars
exclude:
- os: windows-latest
python-version: "3.13"
backend:
name: duckdb
- os: windows-latest
backend:
name: mysql
Expand Down Expand Up @@ -317,7 +352,7 @@ jobs:
- libgeos-dev
# TODO(deepyaman): Test whether this works upon releasing https://github.com/cloudera/impyla/commit/bf1f94c3c4106ded6267d2485c1e939775a6a87f
- os: ubuntu-latest
python-version: "3.12"
python-version: "3.13"
backend:
name: impala
title: Impala
Expand Down Expand Up @@ -383,7 +418,7 @@ jobs:
services:
- oracle
- os: ubuntu-latest
python-version: "3.12"
python-version: "3.13"
backend:
name: flink
title: Flink
Expand Down Expand Up @@ -526,7 +561,7 @@ jobs:
tag: local
deps:
- delta-spark==3.2.1
- python-version: "3.12"
- python-version: "3.13"
pyspark-minor-version: "3.5"
tag: local
deps:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/ibis-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ jobs:
- "3.10"
- "3.11"
- "3.12"
- "3.13"
pyarrow:
- true
- false
Expand Down Expand Up @@ -118,7 +119,7 @@ jobs:
uses: actions/setup-python@v5
id: install_python
with:
python-version: "3.12"
python-version: "3.13"

- name: install uv
uses: astral-sh/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pre-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: install python
uses: actions/setup-python@v5
with:
python-version: "3.12"
python-version: "3.13"

- name: install uv
uses: astral-sh/[email protected]
Expand Down
6 changes: 3 additions & 3 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 11 additions & 4 deletions ibis/backends/sql/compilers/bigquery/udf/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import inspect
import textwrap
from collections import ChainMap
from inspect import _empty as EMPTY
from typing import TYPE_CHECKING

from ibis.backends.sql.compilers.bigquery.udf.find import find_names
Expand Down Expand Up @@ -66,7 +67,7 @@ def wrapper(*args, **kwargs):
return wrapper


@rewrite.register(ast.Call(func=ast.Name(id="print")))
@rewrite.register(ast.Call(func=ast.Name(id="print"), args=EMPTY, keywords=EMPTY))
def rewrite_print(node):
return ast.Call(
func=ast.Attribute(
Expand All @@ -79,13 +80,15 @@ def rewrite_print(node):
)


@rewrite.register(ast.Call(func=ast.Name(id="len")))
@rewrite.register(ast.Call(func=ast.Name(id="len"), args=EMPTY, keywords=EMPTY))
def rewrite_len(node):
assert len(node.args) == 1
return ast.Attribute(value=node.args[0], attr="length", ctx=ast.Load())


@rewrite.register(ast.Call(func=ast.Attribute(attr="append", value=None)))
@rewrite.register(
ast.Call(func=ast.Attribute(attr="append", value=None), args=EMPTY, keywords=EMPTY)
)
def rewrite_append(node):
return ast.Call(
func=ast.Attribute(value=node.func.value, attr="push", ctx=ast.Load()),
Expand All @@ -95,7 +98,11 @@ def rewrite_append(node):


@rewrite.register(
ast.Call(func=ast.Attribute(value=ast.Name(id="Array"), attr="from_"))
ast.Call(
func=ast.Attribute(value=ast.Name(id="Array"), attr="from_"),
args=EMPTY,
keywords=EMPTY,
)
)
def rewrite_array_from(node):
return ast.Call(
Expand Down
3 changes: 2 additions & 1 deletion ibis/backends/sql/compilers/bigquery/udf/rewrite.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from __future__ import annotations

import ast
from inspect import _empty as EMPTY
from typing import TYPE_CHECKING

if TYPE_CHECKING:
Expand All @@ -20,7 +21,7 @@ def matches(value: ast.AST, pattern: ast.AST) -> bool:
fields = [
(field, getattr(pattern, field))
for field in pattern._fields
if hasattr(pattern, field)
if hasattr(pattern, field) and getattr(pattern, field) is not EMPTY
]
return all(
matches(getattr(value, field_name), field_value)
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading