Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update clickhouse/clickhouse-server docker tag to v24.12.1.1614 #10599

Merged
merged 3 commits into from
Dec 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compose.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:
clickhouse:
image: clickhouse/clickhouse-server:24.11.1.2557-alpine
image: clickhouse/clickhouse-server:24.12.1.1614-alpine
ports:
- 8123:8123 # http port
- 9000:9000 # native protocol port
Expand Down
12 changes: 3 additions & 9 deletions ibis/backends/clickhouse/tests/test_select.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from pytest import param

import ibis
from ibis.backends.tests.errors import ClickHouseDatabaseError

cc = pytest.importorskip("clickhouse_connect")

Expand Down Expand Up @@ -189,16 +188,11 @@ def test_physical_table_reference_translate(alltypes, assert_sql):


def test_non_equijoin(alltypes):
t = alltypes.limit(100)
t = alltypes.limit(10)
t2 = t.view()
expr = t.join(t2, t.tinyint_col < t2.timestamp_col.minute()).count()

# compilation should pass
expr.compile()

# while execution should fail since clickhouse doesn't support non-equijoin
with pytest.raises(ClickHouseDatabaseError, match="INVALID_JOIN_ON_EXPRESSION"):
expr.execute()
count = expr.to_pandas()
assert count == 45


@pytest.mark.parametrize(
Expand Down
10 changes: 9 additions & 1 deletion ibis/backends/tests/tpc/ds/test_queries.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ def test_03(date_dim, store_sales, item):
@pytest.mark.notimpl(
["datafusion"], reason="Optimizer rule 'common_sub_expression_eliminate' failed"
)
@pytest.mark.notyet(["clickhouse"], reason="Broken")
def test_04(customer, store_sales, catalog_sales, web_sales, date_dim):
def profile(sales, *, name):
char = name[0]
Expand Down Expand Up @@ -1144,6 +1145,7 @@ def test_18(


@tpc_test("ds")
@pytest.mark.notyet(["clickhouse"], reason="Broken")
def test_19(date_dim, store_sales, item, customer, customer_address, store):
return (
date_dim.join(store_sales, [("d_date_sk", "ss_sold_date_sk")])
Expand Down Expand Up @@ -1301,6 +1303,7 @@ def total_sales(


@tpc_test("ds", result_is_empty=True)
@pytest.mark.notyet(["clickhouse"], reason="Broken")
def test_24(store_sales, store_returns, store, item, customer, customer_address):
ssales = (
store_sales.join(
Expand Down Expand Up @@ -3259,6 +3262,7 @@ def test_63(item, store_sales, date_dim, store):


@tpc_test("ds", result_is_empty=True)
@pytest.mark.notyet(["clickhouse"], reason="Broken")
def test_64(
catalog_sales,
catalog_returns,
Expand Down Expand Up @@ -3422,6 +3426,7 @@ def test_64(


@tpc_test("ds", result_is_empty=True)
@pytest.mark.notyet(["clickhouse"], reason="Broken")
def test_65(store, item, store_sales, date_dim):
sa = (
store_sales.join(
Expand Down Expand Up @@ -3751,12 +3756,13 @@ def test_71(item, web_sales, date_dim, catalog_sales, store_sales, time_dim):
)


@tpc_test("ds")
@pytest.mark.notyet(
["datafusion"],
raises=OperationNotDefinedError,
reason="No DateDelta op defined",
)
@tpc_test("ds")
@pytest.mark.notyet(["clickhouse"], reason="Broken")
def test_72(
catalog_sales,
inventory,
Expand Down Expand Up @@ -3889,6 +3895,7 @@ def test_73(store_sales, date_dim, store, household_demographics, customer):


@tpc_test("ds")
@pytest.mark.notyet(["clickhouse"], reason="Broken")
def test_74(customer, store_sales, date_dim, web_sales):
renames = {
"customer_id": "c_customer_id",
Expand Down Expand Up @@ -5058,6 +5065,7 @@ def test_94(web_sales, date_dim, customer_address, web_site, web_returns):


@tpc_test("ds")
@pytest.mark.notyet(["clickhouse"], reason="Broken")
def test_95(web_sales, date_dim, customer_address, web_site, web_returns):
ws1 = web_sales.view()
ws2 = web_sales.view()
Expand Down
Loading