Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added location service #66

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

psyntium
Copy link

@psyntium psyntium commented Apr 1, 2017

if msg.payload does not contain the latitude and longitude, it will try to use the location services to locate the latitude and longitude, assuming that the payload is a name of a city

Signed-off-by: Syahrul Aiman [email protected]

if msg.payload does not contain the latitude and longitude, it will try to use the location services to locate the latitude and longitude, assuming that the payload is a name of a city

Signed-off-by: Syahrul Aiman <[email protected]>
@psyntium
Copy link
Author

psyntium commented Apr 1, 2017

i've signed the CLA. not sure why it is still saying no CLA on record. Perhaps you can help to check. Thanks!

@knolleary
Copy link
Contributor

Ignore the cla check; forgot to disable it when we moved this repo out of the Node-RED org.

Copy link
Contributor

@jthomas jthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new API call, the error checking code is replicated multiple times within the file.

Can you re-factor the code to reduce this duplication?

Copy link
Contributor

@jthomas jthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the node's info panel to give details on the new functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants