Add a check to detect the OpenJCEPlus module #924
Conversation
taoliult
force-pushed
the
OpenJCEPlus-Check
branch
from
2126df6 to
81d196e
Compare
| if (module.isPresent()) { | ||
| isOpenJCEPlusModuleExist = true; | ||
| } |
There was a problem hiding this comment.
The field should be final and initialized as:
isOpenJCEPlusModuleExist = module.isPresent();| @@ -387,6 +397,11 @@ private static void checkIfKnownProfileSupported() { | |||
| + " on this platform."); | |||
| } | |||
|
|
|||
| if (profileID.contains("OpenJCEPlus") && !isOpenJCEPlusModuleExist) { | |||
There was a problem hiding this comment.
The operands of && should be reversed (doing the cheaper test first).
Add a check to detect the OpenJCEPlus module. If the module is missing but the restricted security profile requires it, print an error message and exit. Signed-off-by: Tao Liu <[email protected]>
taoliult
force-pushed
the
OpenJCEPlus-Check
branch
from
15ac91d to
47366a5
Compare
| @@ -387,6 +394,11 @@ private static void checkIfKnownProfileSupported() { | |||
| + " on this platform."); | |||
| } | |||
|
|
|||
| if (!isOpenJCEPlusModuleExist && profileID.contains("OpenJCEPlus")) { | |||
There was a problem hiding this comment.
This doesn't seem right. Trying to use a profile called "not-OpenJCEPlus" shouldn't demand the presence of the openjceplus module. Also profiles that don't contain that string might actually depend on the openjceplus module.
I would expect to just get "no such provider" or something similar if I try to use an algorithm that requires a module (perhaps openjceplus, but it could be another module) that isn't present in the runtime in use. What are the current symptoms of that situation? Are they really worth potentially breaking legitimate use-cases?
Add a check to detect the OpenJCEPlus module. If the module is missing but the restricted security profile requires it, print an error message and exit.
Signed-off-by: Tao Liu [email protected]