Add abstraction layer to create `EXDATE` and `RDATE` properties #684

axunonb · 2024-12-29T19:41:21Z

Add abstraction layer to create `EXDATE` and `RDATE` properties

Introduce ExceptionDate and RecurrenceDates classes as wrappers for IList<PeriodList> properties.
Periods and CalDateTimes to them can be done without having to care for RFC 5545 rules regarding serialization:. This happens behind the scenes.

IRecurrable

Change the type of ExceptionDates from IList<PeriodList> to ExceptionDates.
Change the type of RecurrenceDates from IList<PeriodList> to RecurrenceDates.

RecurringComponent (inhereted by CalendarEvent and other classes), VTimeZoneInfo

Rename IList<PeriodList> ExceptionDates to ExceptionDatesPeriodLists. This serves as the backing storage for the new ExceptionDates class/property.
Rename IList<PeriodList> RecurrenceDates to RecurrenceDatesPeriodLists. This serves as the backing storage for the new RecurrenceDates class/property.
Add the creation of instances of ExceptionDates and RecurrenceDates to the Initialize() method.

RecurringEvaluator and TodoEvaluator

Implement the new ExceptionDates and RecurrenceDates classes.

VTimeZone

Enhanced serialization:
- Before: Each RDATE date/time was serialized as a separate RDATE propery
- Now: RDATE date/times which can be clustered go into one single RDATE property

Period

Make parameterless CTOR internal to ensure proper initialization by users
Add internal enum PeriodKind to identify the period kind as Undefined, DateTime, DateOnly or Period and property PeriodKind
StartTime, EndTime and Duration are immutable
Timezones and date-only or date-time of StartTimeand (optional) EndTime must be the same
CompareTo uses AsUtc for comparing the StartTime
Remove returning a "magic" duration of 1 day, if EndTime is null and StartTime is date-only. This broke EXDATE and RDATE of an event, when only a start time exists. Full day is handled by PeriodSerializer.
Added EffectiveEndTime and EffectiveDuration properties to provide calculated values based on the set values.

PeriodList

Change access modifier to internal.
Add internal PeriodKind PeriodKind
Add internal string? TzId , returning the TzId of the first period
EnsureConsistentTimezoneAndPeriodKind: The first period determines the TzId and PeriodKind of the PeriodList and all other Periods added or inserted must have these properties as well.
Add SetService(new PeriodListEvaluator(this)) for StringReader CTOR overload
Add Add(IDateTime)
Remove public method GetGroupedPeriods
nullable enable

PeriodListEvaluator

Change access modifier to internal

EventEvaluator:

Update to handle RDATE durations correctly

TodoEvaluator:

Refactor using ExceptionDate and RecurrenceDates classes
Remove method PeriodWithDuration(Period) as it became redudant with the refactored Period class.

RecurringEvaluator:

Refactor using ExceptionDate and RecurrenceDates classes

DataTypeSerializer and other serializers, CalendarObjectBase:

Activator.CreateInstance(TargetType, true) allows for not public CTORs, so that parameterless CTORs can be excluded from the public API, if proper initialization can't be assured (like with Period).

PeriodListSerializer, PeriodSerializer, DateTimeSerializer, PropertySerializer

Update serializers to handle the modified PeriodList implementation.
Never set the UTC timezone ID (use appending 'Z') (Section 3.2.19: The "TZID" property parameter MUST NOT be applied to DATE properties and DATE-TIME or TIME properties whose time values are specified in UTC.)
RDATE and EXDATE serialize following RFC 5545 sections 3.8.5.2 and 3.8.5.1

Resolves #590
Resolves #591
Resolves #614
Resolves #676

axunonb · 2024-12-29T21:17:51Z

@minichma The code changes became more than expected, because it was necessary to revisit Period and PeriodList.
I feel like EXDATE and RDATE should have more unit tests with different scenarios than those in RecurrenceWithRDateTests and RecurrenceWithExDateTests. If so, let me know.
Using the List<PeriodList> for EXDATE brings a disadvantage: Adding a Period with Duration will not throw. But there is a "how to" in the xmldoc, and we have specific methods to add an IDateIme to a PeriodList. This way we don't need extra classes just for EXDATE. Would this be acceptable?

minichma · 2024-12-29T23:14:09Z

Using the List<PeriodList> for EXDATE brings a disadvantage: Adding a Period with Duration will not throw. But there is a "how to" in the xmldoc, and we have specific methods to add an IDateIme to a PeriodList. This way we don't need extra classes just for EXDATE. Would this be acceptable?

I'm pretty sure it is. I see the challenges that come with introducing separate types for lists of Periods and IDateTimes - redundant code, challenges with type safety, inheritance. At the same time I remember the challenges I had when starting with ical.net and not knowing much about the details of RFC 5545. The ExDate property being a list of Periods was not exactly easy to understand at that time. So yes, doc comments will certainly be helpful in this respect. We can still continue thinking about alternatives in the future (maybe not v5 though once it has been released).

axunonb · 2024-12-30T13:59:28Z

Oops, just noticed that
RDATE:20231002/P1D,20231003T100000
is currently possible with PeriodList, but not allowed. The VALUE type of containing elements must be the same - as with timezone. Will fix that.

axunonb · 2025-01-02T09:23:47Z

The ExDate property being a list of Periods was not exactly easy to understand

Creating EXDATE and RDATE can indeed be a pain for users. Now there is an abstraction layer that makes this a breeze.

minichma · 2025-01-02T10:08:14Z

@axunonb Wish you a great 2025! Hope I will find some time for a review this afternoon when I'll be on a train or otherwise tomorrow.

axunonb · 2025-01-02T10:45:13Z

@minichma Happy New Year and thank you!
Just noticed that as of section 3.8.5.1 for day-only EXDATE;VALUE=DATE: must be serialized...
We could start the new year with a first v5 pre release, couldn't we?

Ical.Net.Tests/RecurrenceTests.cs

Ical.Net/Calendar.cs

minichma

This is a challenging one! Left a few comments but they might not be fully consistent. Just take what you think makes sense. Unfortunately I don't have the time right now to go into all the detail that would be required.

Ical.Net/DataTypes/Period.cs

Ical.Net/DataTypes/PeriodList.cs

Ical.Net/DataTypes/Period.cs

Ical.Net/Collections/PeriodCollectionBase.cs

Ical.Net/Collections/ExceptionDateCollection.cs

Ical.Net/DataTypes/PeriodList.cs

Ical.Net/Serialization/DataTypes/PeriodSerializer.cs

axunonb · 2025-01-07T23:57:50Z

@minichma Looks like the failing tests for .Net Framework go back to GitHub upgrading to ubuntu 24.04 as "latest", which is missing mono. Downgrading to ubuntu-22.04 might help: microsoft/sbom-tool#855

Improve reliability and usability for `Period` and `PeriodList` to become less error-prone by enforcing timezones being used consistently Period - Make parameterless CTOR `internal` to ensure proper initialization by users - A period can be defined 1. by a start time and an end time, 2. by a start time and a duration, 3. by a start time only, with the duration unspecified. This is for EXDATE and RDATE date-only and date/time. - For cosistency, either the `EndTime` or the `Duration` can be set at a time. The last one set with a value not `null` will prevail, while the other will become `null`. - Timezones of `StartTime`and (optional) `EndTime` must be the same - `CompareTo` uses `AsUtc` for comparing the `StartTime` - Remove returning a "magic" duration of 1 day, if `EndTime` is null and `StartTime` is date-only. This broke `EXDATE` and `RDATE` of an event, when the only a start time exists. - Added `EffectiveEndTime` and `EffectiveDuration` properties to provide calculated values based on the set values. - Update the `EndTime` and `Duration` properties to directly return the set values. - Change the access modifiers of `GetEffectiveDuration()` and `GetEffectiveEndTime` methods from internal to private. PeriodList - `TzId`: `public` setter changed to `private` - `EnsureConsistentTimezones`: The first period determines the timezone of the `PeriodList` and all other `Period`s added must have the same timezone - Add `SetService(new PeriodListEvaluator(this))` for `StringReader` CTOR overload - Add `static PeriodList FromStringReader(StringReader)` - Add `static PeriodList FromDateTime(IDateTime)` - Add `PeriodList AddPeriod(Period)` for chaining - Add `PeriodList Add(IDateTime)` for chaining - nullable enable EventEvaluator: - `EventEvaluator.WithEndTime(Period)` only sets the `EndTime`, as `Period.EffectiveDuration` returns the duration. TodoEvaluator: - Remove method `PeriodWithDuration(Period)` as it became redudant with the refactored `Period` class. DataTypeSerializer and other serializers, CalendarObjectBase: - `Activator.CreateInstance(TargetType, true)` allows for not `public` CTORs, so that parameterless CTORs can be excluded from the public API, if proper initialization can't be assured (like with `Period`). PropertySerializer: - TBD: Never set the UTC timezone ID (use appending 'Z') - Resolves ical-org#590 - Resolves ical-org#591 - Resolves ical-org#614 - Resolves ical-org#676

PeriodKind - Add new enum Period: - Add internal `property string TzId` - Add internal method `PeriodKind GetPeriodKind()` - Ensure timeone consistence for setters of StartTime / EndTime PeriodList: - Add internal `property string TzId` - Add internal property ``PeriodKind PeriodListKind`m - Ensure added `Period`s have the same `TzId`and `PeriodKind` as the first one added PeriodListSerialilzer - Serializes TZID - Serializes value type PERIOD

- Introduced `ExceptionDateCollection`, `RecurrencePeriodCollection` and PeriodCollectionBase` classes. - Updated serializers to handle the modified `PeriodList` implementation. These classes are an abstraction layer for creating `List<PeriodList>` objects. `Period`s and `CalDateTime`s are accepted without having to care for RFC 5545 rules regarding serialization: `ToRecurrenceDates` and `ToRecurrenceDates` methods aggregate and convert the exception or recurrence `CalDateTime` and `Period` objects into a list of `PeriodList` objects. Periods are grouped by their timezone IDs and period kinds in a way, that each `PeriodList` contains only distinct periods ready to serialize.

- Adjust code in ' EventEvaluator` and `PeriodSerializer` - Method `GetPeriodKind()` is replace with internal property `PeriodKind` - Add internal `Period.Create` to centralize logic if end time and duration exist - Modified unit test

Remove solution for RDATE/ESDATE introduced earlier in this PE The commit removes several test and source files related to period and exception date collections in calendar events. Specifically, the following files have been completely removed: - `PeriodCollectionBase.cs` - `ExceptionDateCollection.cs` - `RecurrencePeriodCollection.cs` - `PeriodCollectionTests.cs` - `RecurrenceWithExDateTests.cs` - `RecurrenceWithRDateTests.cs`

- Add internal properties `PeriodKind` and `TzId` to `PeriodList`. - Modify `Period` indexer and `Insert` to ensure consistency for timezone and `PeriodKind` - Prepare for `PeriodList` to become `internal` - Update `PeriodListSerializer` and `PeriodSerializer` classes for `Period` serialization - Introduce `ExceptionDates`, `RecurrenceDates`, and `PeriodListWrapperBase` to become wrappers around these properties of `RecurringComponent` - Add unit tests in `PeriodListWrapperTests` for `ExceptionDates` and `RecurrenceDates`. Note: The wrappers are not yet implemented for `IRecurringComponent`s.

…nceDates` `IRecurrable` - Change the type of `ExceptionDates` from `IList<PeriodList>` to `ExceptionDates`. - Change the type of `RecurrenceDates` from `IList<PeriodList>` to `RecurrenceDates`. `RecurringComponent`, `VTimeZoneInfo` - Rename `IList<PeriodList> ExceptionDates` to `ExceptionDatesPeriodLists`. This serves as the backing storage for the new `ExceptionDates` class/property. - Rename `IList<PeriodList> RecurrenceDates` to `RecurrenceDatesPeriodLists`. This serves as the backing storage for the new `RecurrenceDates` class/property. - Add the creation of instances of `ExceptionDates` and `RecurrenceDates` to the `Initialize()` method. `PeriodList` and `PeriodListEvaluator` - Change the access modifier to `internal`. `RecurringEvaluator` and `TodoEvaluator` - Implement the new `ExceptionDates` and `RecurrenceDates` classes. `VTimeZone` - Enhanced serialization: - Before: Each `RDATE` date/time was serialized as a separate `RDATE` propery - Now: `RDATE` date/times which can be clustered go into one single `RDATE` property Unit tests - Refactor tests, using `ExceptionDates` and `RecurrenceDates` instead of `IList<PeriodList>` - Remove the duplicate `SimpleDeserializationTests.RecurrenceDates1()` method, which exists in `DeserializationTests.RecurrenceDates1()`. Todo: - Replace the use of `PeriodList.GetGroupedPeriods` in `CalendarEvent.Equals()`.

axunonb · 2025-01-10T09:31:42Z

@minichma Also a long story has end...
The last step was to migrate usage of IList<PeriodList> to ExceptionDates and RecurrenceDates.
Finally PeriodList and PeriodListEvaluator have the internal access modifier
I'll do my own review for all changes tomorrow. Could you have another look at the PR (at least at most relevant parts like ExceptionDates, RecurrenceDates, Period and the serializers? I tried to separate migration steps in the latest 4 commits.

Using this internal method stops recreating `Period`s from `IDateTime` Update comments in PropertySerializer

minichma · 2025-01-11T21:36:04Z

Could you have another look at the PR (at least at most relevant parts like ExceptionDates, RecurrenceDates, Period and the serializers? I tried to separate migration steps in the latest 4 commits.

@axunonb Will be happy to have a look. Could still take a few days though because of family obligations and a busy week.

- No duplicate `Period` instances can be added or inserted into the `PeriodList`. - `RecurrenceDates.GetAllDates()`, `PeriodListWrapperBase.GetAllDates()` and `PeriodListWrapperBase.GetAllPeriodsByKind` return a flattened and ordered list of distinct objects - Update `CalendarEvent.Equals` and `CalendarEvent.GetHashCode` using `ExceptionDates` and `RecurrenceDates` instead of `PeriodList.GetGroupedPeriods` - Remove `PeriodList.GetGroupedPeriods`

minichma

@axunonb Had a rather brief look to the most relevant portions and left a few comments again, maybe some duplicated. Please see, what you can use.

minichma · 2025-01-16T20:14:52Z

Ical.Net/DataTypes/Period.cs


-        StartTime = start ?? throw new ArgumentNullException(nameof(start));
-        EndTime = end;
+        _startTime = start ?? throw new ArgumentNullException(nameof(start), "Start time cannot be null.");


We'd have seen a NPE if start was null, at least if end was not nulll.

minichma · 2025-01-16T20:16:53Z

Ical.Net/DataTypes/Period.cs

+            {
+                null when _duration is null => null,
+                { } endTime => endTime,
+                _ => EffectiveDuration is not null


avoid evaluating EffectiveDuration twice?

minichma · 2025-01-16T20:21:30Z

Ical.Net/DataTypes/Period.cs

        // End time is exclusive
-        return endTime == null || endTime.GreaterThan(dt);
+        return endTime?.GreaterThan(dt) ?? false;


This is a functional change, i.e. if EffectiveEndTime is null. Before dt was considered contained and now it isn't. I assume the new version is better, but just to be sure, this was intentional. Could also throw in such a case, because 'Contains' doesn't make much sense in such a case.

Must be return endTime?.GreaterThan(dt) != false;

minichma · 2025-01-16T20:22:59Z

Ical.Net/DataTypes/Period.cs

@@ -155,14 +226,14 @@ internal IDateTime GetEffectiveEndTime()
    public virtual bool Contains(IDateTime? dt)


This kind of convenience methods could be changed to extension methods (in some future PR)

minichma · 2025-01-16T20:25:38Z

Ical.Net/DataTypes/Period.cs

    public int CompareTo(Period? other)
    {
        if (other == null)
        {
            return 1;
        }

-        if (StartTime.Equals(other.StartTime))
+        if (StartTime.AsUtc.Equals(other.StartTime.AsUtc))


Why do we do a UTC comparison here? I.e. equality is quite a topic in CalDateTime, so why would we use a different comparison here? Do we need the comparison at all? It seems to implement a somewhat special case. I don't think there's a natural order if the duration isn't considered. Maybe remove the comparison altogether and let the caller choose how to compare?

Oh yes, you remember the discussion about CalDateTime equality.
I opened a discussion for that topic.
We can't use Exact Equivalence (same IsFloating and same Value and same HasTime and same TzId) here, because the timezone of 2 Periods may be different. and.AsUtc is a must.

Isn't the CompareTo method specific to each component, that the all callers should "just use".

minichma · 2025-01-16T20:38:51Z

Ical.Net/DataTypes/PeriodListWrapperBase.cs

+    /// <see cref="PeriodKind.Period"/>, <see cref="PeriodKind.DateOnly"/> and <see cref="PeriodKind.DateTime"/>.
+    /// </summary>
+    internal IEnumerable<Period> GetAllPeriodsByKind(params PeriodKind[] periodKinds)
+        => ListOfPeriodList.SelectMany(pl => pl.Where(p => periodKinds.Contains(p.PeriodKind))).OrderedDistinct();


You can use OrderedDistinct only if the list it is applied on is ordered. But this would only be the case if the individual lists would be ordered and they would be merged using OrderedMerge. But do we need to apply a Distinct at all? If the values are duplicated, why not return them here? The method name suggests that 'all' are returned.

Yes - RTD., thanks. When attempting to add a duplicate, it just gets discarded. For consistency, values from deserialization should also be unique.

minichma · 2025-01-16T20:44:08Z

Ical.Net/DataTypes/RecurrenceDates.cs

+    /// </summary>
+    public bool Contains(Period period)
+    {
+        var periodList = GetPeriodList(period);


See above - GetPriodList doesn't necessarily return the right list.

minichma · 2025-01-16T20:44:28Z

Ical.Net/DataTypes/RecurrenceDates.cs

+    /// <inheritdoc cref="PeriodList.Remove"/>
+    public bool Remove(Period period)
+    {
+        var periodList = GetPeriodList(period);


see above, possibly not the right list

minichma · 2025-01-16T20:54:20Z

Ical.Net/CalendarComponents/CalendarEvent.cs

+        // specifies a "DTSTART" property with a DATE value type but no
+        // "DTEND" nor "DURATION" property, the event’s duration is taken to
+        // be one day.
+        // This is taken care of in the PeriodSerializer class,


Don't think we should remove this as the Period only comes into play during evaluation, but the CalendarEvent's duration could be queried independently. Either we remove the method altogether or we return a precise value. We could consolidate the calculation though. I would also not consider this a 'magic number' though. It's just the value that's specified in the RFC.

We have the same kind of logic in multiple places now, so we could consolidate it in a utility class.

Valid point - reverted

minichma · 2025-01-16T20:55:39Z

Ical.Net/CalendarComponents/CalendarEvent.cs

-        var otherRDates = PeriodList.GetGroupedPeriods(other.RecurrenceDates);
-        if (rDates.Keys.Count != otherRDates.Keys.Count || !rDates.Keys.OrderBy(k => k).SequenceEqual(otherRDates.Keys.OrderBy(k => k)))
+        // exDates and otherExDates are filled with a sorted list of distinct periods
+        var exDates = ExceptionDates.GetAllPeriodsByKind(PeriodKind.Period, PeriodKind.DateOnly, PeriodKind.DateTime).ToList();


Do we need an implementation of Equals at all? Not sure.

I guess, we don't for CalendarEvent. Should go into another PR.

sonarqubecloud · 2025-01-17T18:20:09Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

axunonb · 2025-01-18T16:00:44Z

@minichma Thanks for having another look at the PR. As always: very helpful. See the comments for details.

minichma · 2025-01-20T19:57:23Z

@axunonb Your are welcome :)

* Improve line folding and serialization performance - Update line folding to use StringBuilder and ArrayPool<char> for better performance and memory efficiency. - Ensure compliance with RFC 5545 by handling multi-byte characters correctly. - Add System.Buffers package for netstandard2.0 target framework. Resolves #693 * Remove code redundant after #684 * Replace usage of ArrayPool, remove dependency System.Buffers

axunonb force-pushed the pr/exdate-rdate branch 3 times, most recently from 9d19aa8 to f09b049 Compare December 29, 2024 20:40

axunonb mentioned this pull request Dec 29, 2024

Exdate not taken correctly into account when getting the FreeBusyStatus? #590

Closed

axunonb marked this pull request as ready for review December 30, 2024 10:14

axunonb requested a review from minichma December 30, 2024 10:14

axunonb marked this pull request as draft December 30, 2024 17:33

axunonb force-pushed the pr/exdate-rdate branch 2 times, most recently from 76a047e to 9eef103 Compare January 2, 2025 09:13

axunonb marked this pull request as ready for review January 2, 2025 09:24

axunonb force-pushed the pr/exdate-rdate branch from 9eef103 to f762d8f Compare January 2, 2025 10:34

axunonb commented Jan 3, 2025

View reviewed changes

Ical.Net.Tests/RecurrenceTests.cs Outdated Show resolved Hide resolved

axunonb commented Jan 3, 2025

View reviewed changes

Ical.Net/Calendar.cs Show resolved Hide resolved

minichma reviewed Jan 5, 2025

View reviewed changes

axunonb force-pushed the pr/exdate-rdate branch from f762d8f to b54ca8c Compare January 5, 2025 20:59

axunonb force-pushed the pr/exdate-rdate branch 2 times, most recently from 0842c10 to e190317 Compare January 8, 2025 23:20

axunonb added 6 commits January 9, 2025 00:50

Add unit tests to RecurrenceWithRDateTests

0d68f17

Insert values about failure to Exception.Messages

49798e4

axunonb force-pushed the pr/exdate-rdate branch 3 times, most recently from 66a1611 to fca144a Compare January 9, 2025 00:02

axunonb force-pushed the pr/exdate-rdate branch from fca144a to 3800f1c Compare January 9, 2025 16:33

axunonb force-pushed the pr/exdate-rdate branch from 9f7d6ef to 3817d85 Compare January 10, 2025 09:02

Add PeriodListWrapperBase.GetAllPeriodsByKind

f2e9c19

Using this internal method stops recreating `Period`s from `IDateTime` Update comments in PropertySerializer

axunonb changed the title ~~Fix Period and PeriodList to work with EXDATE and RDATE~~ Add abstraction layer to create EXDATE and RDATE properties Jan 11, 2025

axunonb force-pushed the pr/exdate-rdate branch from 14b0187 to dc4f248 Compare January 11, 2025 22:51

Add EXDATE and RDATE unit tests mentioned in issues

bdd7f33

minichma reviewed Jan 16, 2025

View reviewed changes

Updates after revview 2025-01-16

0e78037

axunonb merged commit 391c624 into ical-org:main Jan 17, 2025
4 checks passed

This was referenced Jan 19, 2025

Migrating to iCal.net Period - Matches Date Only #317

Open

RDATE deserialization: Can't keep apart Periods and Dates/Times #570

Closed

axunonb mentioned this pull request Jan 20, 2025

Improve line folding and serialization performance #695

Merged

axunonb added a commit to axunonb/ical.net that referenced this pull request Jan 20, 2025

Remove code redundant after ical-org#684

1475742

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add abstraction layer to create `EXDATE` and `RDATE` properties #684

Add abstraction layer to create `EXDATE` and `RDATE` properties #684

axunonb commented Dec 29, 2024 •

edited

Loading

axunonb commented Dec 29, 2024

minichma commented Dec 29, 2024

axunonb commented Dec 30, 2024

axunonb commented Jan 2, 2025

minichma commented Jan 2, 2025

axunonb commented Jan 2, 2025

minichma left a comment

axunonb commented Jan 7, 2025

axunonb commented Jan 10, 2025

minichma commented Jan 11, 2025

minichma left a comment

minichma Jan 16, 2025

axunonb Jan 17, 2025

minichma Jan 16, 2025

axunonb Jan 17, 2025

minichma Jan 16, 2025

axunonb Jan 17, 2025

minichma Jan 16, 2025

axunonb Jan 17, 2025

minichma Jan 16, 2025

axunonb Jan 17, 2025

minichma Jan 16, 2025

axunonb Jan 17, 2025 •

edited

Loading

minichma Jan 16, 2025

minichma Jan 16, 2025

minichma Jan 16, 2025

axunonb Jan 17, 2025

minichma Jan 16, 2025

axunonb Jan 17, 2025

sonarqubecloud bot commented Jan 17, 2025

axunonb commented Jan 18, 2025

minichma commented Jan 20, 2025

		@@ -155,14 +226,14 @@ internal IDateTime GetEffectiveEndTime()
		public virtual bool Contains(IDateTime? dt)

Add abstraction layer to create EXDATE and RDATE properties #684

Add abstraction layer to create EXDATE and RDATE properties #684

Conversation

axunonb commented Dec 29, 2024 • edited Loading