Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome packaged app #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Chrome packaged app #12

wants to merge 2 commits into from

Conversation

matthewp
Copy link

This contains a Chrome packaged app for webwriter. I wouldn't merge this into master as it overrides save. Instead of saving to localStorage it uses the chrome.fileSystem api to open and save to the filesystem. That is the main difference with my fork. There's also some minor stylistic changes, like a custom scrollbar (the default scrollbars look terrible on a Chromebook).

I only send this pull request in case you want to "own" this branch and release it into the Web Store. There is a bug in Chrome 29 (current stable branch) that makes the caretRangeFromPoint you're using not work in packaged app, but it's fixed in Chrome 30. So I wouldn't publish this until whenever it's fixed in stable.

If you don't about packaged apps or Chromebooks just let me know and I'll be the publisher. Either way, great project!

@icebeat
Copy link
Owner

icebeat commented Sep 2, 2013

Wow! thanks a lot for this work. I had this in my mind for a long time but i couldn't do it.

I'll do an new icon and some little changes. We'll be in touch :).

Do you recommend me a new repo for chromeos?

Thanks @matthewp

@matthewp
Copy link
Author

matthewp commented Sep 2, 2013

You can either do a new repo or just maintain this in a chrome branch, either will work fine.

@ryansnowden
Copy link

Did you manage to do it? 👯

@matthewp
Copy link
Author

matthewp commented Oct 1, 2015

This would still be nice...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants