Skip to content
This repository has been archived by the owner on Aug 13, 2024. It is now read-only.

fix manifest statistics: added_files_count, deleted_files_count and existing_files_count #280

Closed
wants to merge 1 commit into from

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Aug 13, 2024

  • added_data_files_count should be changed to added_files_count
  • existing_data_files_count should be changed to existing_files_count
  • deleted_data_files_count should be changed to deleted_files_count
    as the spec https://arc.net/l/quote/rlusxtoo

Otherwise, spark would filter the manifest if added_files_count equals 0

@chenzl25 chenzl25 changed the title fix manifest statistics: added_files_count, existing_files_count and existing_files_count fix manifest statistics: added_files_count, deleted_files_count and existing_files_count Aug 13, 2024
@Xuanwo
Copy link
Contributor

Xuanwo commented Aug 13, 2024

Thanks for the PR, but this repo doesn't accept any PRs anymore. Sorry for the inconvenience.

Read more about this in #279

@Xuanwo Xuanwo closed this Aug 13, 2024
@chenzl25
Copy link
Contributor Author

It is a critical fix 🥵

@Xuanwo
Copy link
Contributor

Xuanwo commented Aug 13, 2024

It is a critical fix 🥵

I apologize for the inconvenience. I understand that this happens. The best solution might be to fork icelake so you can continue using and modifying it before we finish the migration to iceberg-rust.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants