-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send invitations to users and groups #138
Send invitations to users and groups #138
Conversation
Will this work with the new endpoint that creates multiple rooms at once, as introduced by #134 ? |
90b7b97
to
9bd4d7d
Compare
9bd4d7d
to
5d1106f
Compare
It didn't, I think. As I was rebasing this to the current Main branch, I got a merge conflict. By fixing that, I introduced the fix required for that. |
@Fishbowler we force-pushed at about the same time. Yours seems to have gone in slighty before mine, which means that I've just overwritten your changes. |
Diff'd. Yours were better changes anyway 👍 |
fix for igniterealtime#128 Send invitations to affiliated users and groups fix for igniterealtime#129 New endpoint to send invitations to selected users and groups
5d1106f
to
9ee585d
Compare
The "newly" bit of "newly affiliated users" doesn't appear to be working. When I call the room update endpoint twice with the same payload and query string, I get invitations both times. |
…tions when updating a room
New commit introduces some basic analysis of which affiliations are actually newly new in an update scenario. This should fix the problem: I don't get an invitation anymore the second time around. |
This PR adds functionality for sending invitations to users and groups. In two distinct ways: whenever a mutation is performed that causes new affiliations to exist, and explicitly by calling a specialised endpoint to send invitation messages.
Sending invitations is always optional, and the default is to not send any invitations.
Fixes #128.
Fixes #129.