Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send invitations to users and groups #138

Conversation

evdherberg
Copy link
Contributor

@evdherberg evdherberg commented Jul 29, 2022

This PR adds functionality for sending invitations to users and groups. In two distinct ways: whenever a mutation is performed that causes new affiliations to exist, and explicitly by calling a specialised endpoint to send invitation messages.

Sending invitations is always optional, and the default is to not send any invitations.

Fixes #128.
Fixes #129.

@evdherberg evdherberg requested a review from guusdk July 29, 2022 15:26
@guusdk
Copy link
Member

guusdk commented Jul 31, 2022

Will this work with the new endpoint that creates multiple rooms at once, as introduced by #134 ?

@Fishbowler Fishbowler force-pushed the feature/128-send-invitations-to-affiliated-users branch from 90b7b97 to 9bd4d7d Compare July 31, 2022 14:32
@guusdk guusdk force-pushed the feature/128-send-invitations-to-affiliated-users branch from 9bd4d7d to 5d1106f Compare July 31, 2022 14:32
@guusdk
Copy link
Member

guusdk commented Jul 31, 2022

Will this work with the new endpoint that creates multiple rooms at once, as introduced by #134 ?

It didn't, I think. As I was rebasing this to the current Main branch, I got a merge conflict. By fixing that, I introduced the fix required for that.

@guusdk
Copy link
Member

guusdk commented Jul 31, 2022

@Fishbowler we force-pushed at about the same time. Yours seems to have gone in slighty before mine, which means that I've just overwritten your changes.

@Fishbowler
Copy link
Member

Diff'd. Yours were better changes anyway 👍

fix for igniterealtime#128 Send invitations to affiliated users and groups
fix for igniterealtime#129 New endpoint to send invitations to selected users and groups
@guusdk guusdk force-pushed the feature/128-send-invitations-to-affiliated-users branch from 5d1106f to 9ee585d Compare July 31, 2022 14:41
@Fishbowler
Copy link
Member

The "newly" bit of "newly affiliated users" doesn't appear to be working. When I call the room update endpoint twice with the same payload and query string, I get invitations both times.

@evdherberg
Copy link
Contributor Author

New commit introduces some basic analysis of which affiliations are actually newly new in an update scenario. This should fix the problem: I don't get an invitation anymore the second time around.

@guusdk guusdk merged commit adce6ea into igniterealtime:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants