Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve image metadata in xarray <-> Dataset conversions #233

Conversation

gselzer
Copy link
Contributor

@gselzer gselzer commented Nov 3, 2022

Closes #200, #198

But we still need to figure out what "preserving image metadata" means in many cases. With the name, it's obvious, as both data structures have that as state. With other metadata like ImageMetadata, it's less obvious.

But discussion should go in #200

@gselzer gselzer added the enhancement New feature or request label Nov 3, 2022
@gselzer gselzer added this to the 1.3.0 milestone Nov 3, 2022
@gselzer gselzer requested review from ctrueden and elevans November 3, 2022 18:21
@gselzer gselzer self-assigned this Nov 3, 2022
@gselzer gselzer linked an issue Nov 3, 2022 that may be closed by this pull request
@ctrueden ctrueden force-pushed the 200-converting-between-xarray-and-dataset-should-convert-attrs-types-better branch from ef0687e to 2ea4076 Compare November 11, 2022 20:11
@ctrueden ctrueden marked this pull request as ready for review November 11, 2022 20:11
@codecov-commenter
Copy link

Codecov Report

Base: 22.23% // Head: 22.23% // No change to project coverage 👍

Coverage data is based on head (ce9d3a5) compared to base (0d9df8e).
Patch has no changes to coverable lines.

❗ Current head ce9d3a5 differs from pull request most recent head 2ea4076. Consider uploading reports for the commit 2ea4076 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #233   +/-   ##
=======================================
  Coverage   22.23%   22.23%           
=======================================
  Files          17       17           
  Lines        1781     1781           
=======================================
  Hits          396      396           
  Misses       1385     1385           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ctrueden ctrueden force-pushed the 200-converting-between-xarray-and-dataset-should-convert-attrs-types-better branch from 2ea4076 to 2437cb1 Compare November 11, 2022 20:31
@ctrueden ctrueden merged commit 570ff57 into master Nov 11, 2022
@ctrueden ctrueden deleted the 200-converting-between-xarray-and-dataset-should-convert-attrs-types-better branch November 11, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants