Implement the base of a sphere and test it #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eulovi
force-pushed
the
implement-base-sphere
branch
2 times, most recently
from
1b4a04d to
665b681
Compare
There was a problem hiding this comment.
Thanks @eulovi for the contribution, I added some comments.
eulovi
force-pushed
the
implement-base-sphere
branch
from
665b681 to
41c2c3a
Compare
eulovi
force-pushed
the
implement-base-sphere
branch
from
41c2c3a to
3aeea4f
Compare
isteinbrecher
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A patch describing a section of the surface of a sphere is implemented. This patch can be rotated to create a complete sphere.