Speed up the repeat expansion window by optimizing SQL #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is too complicated, imho. I would just fill a DBTable with all the data from the repeat_expansion table. |
marc-sturm
reviewed
Jan 14, 2025
src/GSvar/RepeatExpansionWidget.cpp
Outdated
| NGSD db; | ||
| SqlQuery re_query = db.getQuery(); | ||
| re_query.exec("SELECT * FROM repeat_expansion"); | ||
| QList<QMap<QString, QString>> re_table_data; |
There was a problem hiding this comment.
It was easier to use, I guess. Can I use the filtering from DBTable to find id by region and repeat_unit?
There was a problem hiding this comment.
You can use the same loop as you do now.
You just have to determine the column indices before the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes the table is created 8-9 times faster