Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add compatibility with php83 #58

Merged
merged 1 commit into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:

strategy:
matrix:
php: ['8.0', '8.1', '8.2']
php: ['8.0', '8.1', '8.2', '8.3']

name: PHP ${{ matrix.php }}

Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ docker compose up --build -d
Now you can run commands needed to work on the project. For example, say you want to install the dependencies on PHP 8.0:

```console
docker-compose run php-80 composer install
docker compose run php-80 composer install
```

or for enter in the container

```console
docker-compose exec php-80 sh
docker compose exec php-80 sh
```

## Testing
Expand Down
6 changes: 4 additions & 2 deletions docker-compose.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
version: '3.9'

services:
php-80: &php
build: docker/php-8.0
Expand All @@ -16,3 +14,7 @@ services:
<<: *php
build: docker/php-8.2
container_name: braze-php-sdk-8.2
php-83:
<<: *php
build: docker/php-8.3
container_name: braze-php-sdk-8.3
3 changes: 3 additions & 0 deletions docker/php-8.3/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
FROM php:8.3-cli-alpine3.19

COPY --from=composer:latest /usr/bin/composer /usr/local/bin/composer
Loading