feat: add support for timeouts #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: ClientAdapterInterface has 4 new methods
antonioturdo
force-pushed
the
feat/timeout-support
branch
from
2f05c97 to
eb6bbc6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
============================================
+ Coverage 99.57% 99.59% +0.01%
- Complexity 500 516 +16
============================================
Files 139 139
Lines 947 981 +34
============================================
+ Hits 943 977 +34
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
JellyBellyDev
requested changes
Nov 22, 2024
|
The first commit includes the BREAKING CHANGE line in the description. Isn't that enough? |
|
Sorry, i don't know why but yesterday I don't see it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Proposed changes
Add support for connection and overall timeouts.
⚙️ Types of changes