Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: README has a wrong setting name 'import/resolvers' #328

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

ueda-soma
Copy link
Contributor

This pr removes s from import/resolvers in flat-config's settings with eslint-plugin-import on README.md.

  • According to eslint-plugin-import, the setting name seems to be import/resolver.
  • With .eslintrc, README.md has already import/resolver.

Background

With import/resolvers eslint shows these errors on my environment:

  4:37  error  Unable to resolve path to module '@/constants'                       import/no-unresolved

With import/resolver, no errors are shown.

tsconfig.json

{
  "extends": "./node_modules/@tsconfig/node20/tsconfig.json",
  "compilerOptions": {
    // ...
    "paths": {
      "@/*": ["./src/*"]
    }
  }
}

foo.ts

import { slackUserCacheTable } from '@/constants';

Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: 75fd60a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codesandbox-ci bot commented Dec 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Collaborator

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SukkaW SukkaW added this pull request to the merge queue Dec 5, 2024
Merged via the queue into import-js:master with commit d1807bd Dec 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants