Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to tinyglobby #330

Merged
merged 4 commits into from
Dec 15, 2024
Merged

chore: switch to tinyglobby #330

merged 4 commits into from
Dec 15, 2024

Conversation

benmccann
Copy link
Contributor

Copy link

changeset-bot bot commented Dec 14, 2024

⚠️ No Changeset found

Latest commit: 71b1a64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

socket-security bot commented Dec 14, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@benmccann
Copy link
Contributor Author

I'm having a bit of a hard time here, which I suspect is because I don't have much yarn knowledge as most open source projects I encounter use npm or pnpm. It was producing a huge diff to the lockfile and failures I don't understand

I dropped the change to the lockfile as a result. @JounQin any chance you could update the lockfile for me or check if there's something specific to the setup of this project that I'm missing?

@SukkaW
Copy link
Collaborator

SukkaW commented Dec 15, 2024

I'm having a bit of a hard time here, which I suspect is because I don't have much yarn knowledge as most open source projects I encounter use npm or pnpm. It was producing a huge diff to the lockfile and failures I don't understand

I dropped the change to the lockfile as a result. @JounQin any chance you could update the lockfile for me or check if there's something specific to the setup of this project that I'm missing?

Hello, currently I am also the maintainer of eslint-import-resolver-typescript. Lemme update the lockfile~

Copy link

codesandbox-ci bot commented Dec 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@benmccann
Copy link
Contributor Author

Awesome! Thank you so much for the help!

The changes look good to me. Let me know if there's anything else you'd like me to update in this PR or if it looks good

@SukkaW SukkaW added this pull request to the merge queue Dec 15, 2024
Merged via the queue into import-js:master with commit 0fd4eea Dec 15, 2024
9 checks passed
@benmccann benmccann deleted the tinyglobby branch December 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants