added import_style parameter to generate import statements for browser that support es6 #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
import_style
parameter with the only meaningful valuees6
, it affect onlyservice=grpc-web
generation code. The purpose of this is generate import/export code that doesn't need browserify,webpack or similar bundler to work in browser that supports es6.new Buffer
toBuffer.from
due this depracation warning.I need this to use protoc-gen-ts to generate service js file usable in sveltejs + vitejs (rollup bundler).
Passing the
import_style
param like--ts_out=service=grpc-web,import_style=es6
therequire(...)
statements are replaced byimport * as ... from ...
statements, andexports. .... = ...
byexport {...}
statements.Verification
I checked it with a tiny sveltjs+vitejs application.