Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] respect sender.default.senderEmail for sender mail TO fallback #742

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jpmschuler
Copy link
Contributor

In current powermail 8.4.1 I have a form with empty settings.flexform.sender.email (yay editors) and sender mail enabled. Now the email is send to the server admin email address (dunno taken from which setting yet).

For the recipient email I can define the

  • FROM with plugin.tx_powermail.settings.setup.receiver.default.senderEmail and the
  • TO with plugin.tx_powermail.settings.setup.receiver.email

For the sender email doing the same the

  • FROM is plugin.tx_powermail.settings.setup.sender.email and
  • plugin.tx_powermail.settings.setup.sender.default.senderEmail gets ignored thus the TO falls back to my server admin email address.

The code shows a lookup for senderName but not for senderEmail, thus I propose to copy that code for senderEmail, too.

@jpmschuler
Copy link
Contributor Author

closed as more detailed tests fail, will reopen as soon as stable

@jpmschuler jpmschuler closed this Mar 14, 2022
@jpmschuler jpmschuler reopened this Mar 14, 2022
@einpraegsam einpraegsam force-pushed the develop branch 4 times, most recently from a31ca4e to 43b5957 Compare July 8, 2022 10:49
@mschwemer mschwemer deleted the branch in2code-de:master December 28, 2023 10:19
@mschwemer mschwemer closed this Dec 28, 2023
@mschwemer mschwemer reopened this Dec 28, 2023
@mschwemer mschwemer changed the base branch from develop to master September 25, 2024 12:42
@mschwemer
Copy link
Collaborator

Hi @jpmschuler

Thanks for your contribution. This makes totally sense.

Would you mind to rebase it onto the current master and make it compatible with TYPO3 v12. I'd really appreciate it.

@jpmschuler
Copy link
Contributor Author

Can look into it during my migration to 12LTS in the next days and weeks, so no clear ETA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants