Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: Line-height issue in [type='file'] #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# [upcoming 5.3.2]

* Fix bug with line-height of input[type="file"]

# 5.3.1

* Remove @warn from link helpers because they are printed even when the extensions aren't being used (and it's annoying)
Expand Down
3 changes: 1 addition & 2 deletions incuna-sass/components/_forms.sass
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,7 @@ input[type="submit"]
height: auto

// Set the height of select and file controls to match text inputs
select,
input[type="file"]
select
// In IE7, the height of the select element cannot be changed by height, only font-size
height: rem(28px)
line-height: rem(28px)
Expand Down