Clean up deprecations #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
commented
Dec 27, 2024
alexfikl
commented
Dec 27, 2024
Comment on lines
116
to
118
| pointer = pycuda.driver.mem_alloc(length * 4) | ||
| pycuda.driver.memset_d32(pointer, constant_value, length) | ||
| a = pycuda.gpuarray.GPUArray((length,), np.int32, gpudata=pointer) |
There was a problem hiding this comment.
This example doesn't work for me. It dies somewhere around here when calling module.adjacentDifference(a) with
TypeError: No registered converter was able to produce a C++ rvalue of type unsigned long long from this Python object of type DeviceAllocation
Not quite sure if that's some change in pycuda that wasn't updated here or what :(
alexfikl
commented
Dec 27, 2024
| @@ -166,7 +168,8 @@ def compile(self, toolchain, **kwargs): | |||
| """ | |||
|
|
|||
| from codepy.libraries import add_boost_python | |||
| toolchain = toolchain.copy() | |||
|
|
|||
| toolchain = replace(toolchain) | |||
There was a problem hiding this comment.
Also not sure if this replace does what it should. All libraries, includes, etc, in toolchain are lists and this just performs a shallow copy..
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up some deprecations and makes sure the examples still run.