Upstream generators #158
Merged
Upstream generators #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is amazing, I'd really like to use the typescript scaffolds you've created. Do you need any assistance in getting this PR ready for review? |
|
@jacobmichels thanks for the ping! I hope to finish this PR in couple days, my current goal is to implement a simple smoke test that will generate new Rails app, install inertia, generate some scaffolds and run system tests. |
skryukov
force-pushed
the
upstream-generators
branch
17 times, most recently
from
4a4982c to
d6638ef
Compare
skryukov
force-pushed
the
upstream-generators
branch
from
d6638ef to
6cff2e8
Compare
skryukov
force-pushed
the
upstream-generators
branch
from
52cba68 to
189ffb6
Compare
bknoles
reviewed
Nov 27, 2024
| module Generators | ||
| class JSPackageManager | ||
| def self.package_managers | ||
| %w[npm yarn bun pnpm] |
There was a problem hiding this comment.
Gonna point to this file next time I need an example of why the JS ecosystem feels like the wild west compared to Ruby 😅
bknoles
reviewed
Nov 27, 2024
| module Generators | ||
| module Helper | ||
| class << self | ||
| def guess_the_default_framework |
bknoles
reviewed
Nov 27, 2024
| require_relative '../../../lib/generators/inertia/install/install_generator' | ||
| require 'generator_spec' | ||
|
|
||
| RSpec.describe Inertia::Generators::InstallGenerator, type: :generator do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upstreams generators from https://github.com/skryukov/inertia_rails-contrib
TODO: