Avoid monkey patching #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the patches directory to leverage Ruby's module prepend mechanism instead of direct `class_eval` calls. This will introduce dedicated modules under the `InertiaRails` namespace that are systematically prepended to their target classes. This architectural change offers several benefits: - Improves debugging capabilities through clearer stack traces - Better encapsulation of Rails core modifications - More maintainable and predictable method lookup chain The new approach provides a cleaner separation of concerns while maintaining the same functional behavior of the original implementation. This commit rewrites the code in patches directory to avoid calling `class_eval` directly. Instead, it defines modules defined under `InertiaRails` namespaces that get prepended to their respective classes. This should make things easier to debug as well as keeping the code responsible for modifying the core Rails logic encapsulated
bknoles
approved these changes
Nov 21, 2024
|
looks good! Thanks @adrianpacala |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the patches directory to leverage Ruby's module prepend mechanism instead of direct
class_evalcalls. This will introduce dedicated modules under theInertiaRailsnamespace that are systematically prepended to their target classes.This architectural change offers several benefits:
The new approach provides a cleaner separation of concerns while maintaining the same functional behavior of the original implementation.