Fix to_hash called on errors raises an error #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skryukov
force-pushed
the
fix-to-hash
branch
from
8a96077 to
c9f1fe4
Compare
skryukov
force-pushed
the
fix-to-hash
branch
from
c9f1fe4 to
3854acc
Compare
bknoles
reviewed
Nov 28, 2024
| @@ -54,11 +63,14 @@ jobs: | |||
| uses: ruby/setup-ruby@v1 | |||
| with: | |||
| ruby-version: ${{ matrix.ruby }} | |||
| # Use the latest version of RubyGems with Ruby 3.0 to avoid: | |||
| # https://bugs.ruby-lang.org/issues/19371 | |||
| rubygems: ${{ startsWith(matrix.ruby-version, '3.0') && 'latest' || 'default' }} | |||
There was a problem hiding this comment.
i thought i was going crazy for a second because I was sure I'd already merged something like this in... but that was in #162 that targeted the v2 branch 😅
There was a problem hiding this comment.
Yup yup I decided it's good to have it in master as well 😄
There was a problem hiding this comment.
yea i forgot that you added Ruby 3.0 CI support as part of V2! definitely worth supporting that in master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166 and adds a deprecation warning to prepare for requiring hashes in a future major update.