Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve framework detection logic and add test coverage #174

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improve framework detection logic and add test coverage #174

wants to merge 4 commits into from
+83 −7

Conversation

brodienguyen
Copy link

@brodienguyen brodienguyen commented Dec 6, 2024 •
edited
Loading

This PR performs some changes:

  • Update logic to handle Svelte 5 dependencies with caret (^x.x.x), exact (x.x.x), and tilde (~x.x.x) versioning to prevent exceptions when using the controller generator.
  • Add test coverage for the InertiaRailsContrib::GeneratorsHelper#guess_the_default_framework method.
Before After
BrodieMFL 2024-12-07 at 02 40 49 BrodieMFL 2024-12-07 at 02 40 16

@brodienguyen brodienguyen marked this pull request as ready for review December 6, 2024 15:41
@brodienguyen brodienguyen mentioned this pull request Dec 6, 2024
Closed
@brodienguyen
Copy link
Author

@BrandonShar Could you help me to review this PR whenever you have some spare times please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brodienguyen