Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename WhenVisible "elementTag" prop to "as" #2009

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Rename WhenVisible "elementTag" prop to "as" #2009

merged 1 commit into from
Oct 11, 2024

Conversation

pedroborges
Copy link
Collaborator

No description provided.

@pedroborges pedroborges added the svelte Related to the svelte adapter label Oct 10, 2024
joetannenbaum
joetannenbaum approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@joetannenbaum joetannenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@joetannenbaum joetannenbaum merged commit a3708b4 into master Oct 11, 2024
7 of 8 checks passed
@joetannenbaum joetannenbaum deleted the when-visible-prop branch October 11, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joetannenbaum joetannenbaum joetannenbaum approved these changes

Assignees
No one assigned
Labels
svelte Related to the svelte adapter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedroborges @joetannenbaum