Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Fix onClick in React adapter #2019

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[2.x] Fix onClick in React adapter #2019

merged 1 commit into from
Oct 11, 2024

Conversation

pedroborges
Copy link
Collaborator

Right now, onClick handlers passed to the React <Link /> component are only called when the prefetch mode is click as reported in #2018. This is PR fixes that.

Closes #2018.

@pedroborges pedroborges added bug Something isn't working react Related to the react adapter labels Oct 11, 2024
Copy link
Contributor

@joetannenbaum joetannenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@joetannenbaum joetannenbaum merged commit f055fbd into master Oct 11, 2024
8 checks passed
@joetannenbaum joetannenbaum deleted the fix-onClick-react branch October 11, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working react Related to the react adapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inertia V2 beta - onClick doesn't get called anymore
2 participants