Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Fix issue where initial page data is coming from history state #2023

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

joetannenbaum
Copy link
Contributor

When we initially decrypt the history state so that the router can restore any remembered data, we were setting it as the current history in the History class, causing the page to be loaded from that state rather than the initial page props on the page.

The page would then load the initial page props, but you'd get a flash of stale data.

This fixes that issue by storing the restore data as a separate one-time-use property.

@joetannenbaum joetannenbaum merged commit 93a1fd8 into master Oct 11, 2024
8 checks passed
@joetannenbaum joetannenbaum deleted the reload-issue branch October 11, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant