Correctly encrypt history state, fixes #2028 #2029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buhrmi
changed the title
skryukov
reviewed
Oct 14, 2024
| @@ -47,9 +47,7 @@ const encryptData = async (iv: Uint8Array, key: CryptoKey, data: any) => { | |||
|
|
|||
| const textEncoder = new TextEncoder() | |||
| const str = JSON.stringify(data) | |||
| const encoded = new Uint8Array(str.length) | |||
There was a problem hiding this comment.
If we still want to use more performant encodeInto and not deal with UTF-8 issues, we can use str.length * 3: https://developer.mozilla.org/en-US/docs/Web/API/TextEncoder/encodeInto#buffer_sizing
There was a problem hiding this comment.
I'd rather have smaller history state. Already dumping lots of stuff in there, don't want it 3x the size
|
Thanks for your pull request! I didn't see this until after I had one already open, sorry about that. I'm going to close this in favor of #2030 since that one still uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.