Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] feat: support react 19 #2119

Closed

Conversation

jordyvanderhaegen
Copy link
Contributor

Hi, this PR adds support for React 19.
Additionally, I've also included React 19 to be used in the playground environment.

@jordyvanderhaegen jordyvanderhaegen changed the title feat: support react 19 [2.x] feat: support react 19 Dec 7, 2024
@jordyvanderhaegen
Copy link
Contributor Author

Svelte tests failing seems to be unrelated.

@jordyvanderhaegen
Copy link
Contributor Author

@GraxMonzo that would require all other react versions to be dropped for the 2.x release, right?
Not sure if that's something the maintainers are up to.

Seems like forwardRef is indeed deprecated, so migrating away from it will have to happen at some point.
https://react.dev/reference/react/forwardRef

@reinink
Copy link
Member

reinink commented Dec 13, 2024

@jordyvanderhaegen hey I'm sorry, totally went and added support for React 19 (see #2131) without seeing this. My bad, and thanks anyway! 🙏

@reinink reinink closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants